This is an archive of the discontinued LLVM Phabricator instance.

[mlir][standalone] Specify python path when configuring
ClosedPublic

Authored by rkayaith on Sep 19 2022, 7:20 PM.

Download Raw Diff

Details

Reviewers

stellaraccident
bondhugula

Commits

rG04df971d65a7: [mlir][standalone] Specify python path when configuring

Summary

Specifying the python path here ensures that the python binary used matches the
one used by the main MLIR tests. This is useful when cmake's automatic detection
has to be overridden.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

rkayaith created this revision.Sep 19 2022, 7:20 PM

Herald added a project: Restricted Project. · View Herald TranscriptSep 19 2022, 7:20 PM

Herald added subscribers: bzcheeseman, sdasgup3, wenzhicui and 18 others. · View Herald Transcript

rkayaith published this revision for review.Sep 19 2022, 8:45 PM

rkayaith edited the summary of this revision. (Show Details)

rkayaith added a reviewer: stellaraccident.

Herald added a project: Restricted Project. · View Herald TranscriptSep 19 2022, 8:46 PM

Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript

Harbormaster completed remote builds in B187668: Diff 461450.Sep 19 2022, 8:57 PM

This is a good catch. LGTM.

This revision is now accepted and ready to land.Sep 20 2022, 12:07 PM

Oh, wow - not sure how that was missed. Thanks.

Closed by commit rG04df971d65a7: [mlir][standalone] Specify python path when configuring (authored by rkayaith). · Explain WhySep 20 2022, 12:43 PM

This revision was automatically updated to reflect the committed changes.

rkayaith added a commit: rG04df971d65a7: [mlir][standalone] Specify python path when configuring.

Revision Contents

Path

Size

mlir/

test/

Examples/

standalone/

test.toy

3 lines

Diff 461660

mlir/test/Examples/standalone/test.toy

	# RUN: %cmake_exe %mlir_src_root/examples/standalone -G "%cmake_generator" \			# RUN: %cmake_exe %mlir_src_root/examples/standalone -G "%cmake_generator" \
	# RUN: -DCMAKE_CXX_COMPILER=%host_cxx -DCMAKE_C_COMPILER=%host_cc \			# RUN: -DCMAKE_CXX_COMPILER=%host_cxx -DCMAKE_C_COMPILER=%host_cc \
	# RUN: -DLLVM_ENABLE_LIBCXX=%enable_libcxx -DMLIR_DIR=%mlir_cmake_dir \			# RUN: -DLLVM_ENABLE_LIBCXX=%enable_libcxx -DMLIR_DIR=%mlir_cmake_dir \
	# RUN: -DLLVM_USE_LINKER=%llvm_use_linker			# RUN: -DLLVM_USE_LINKER=%llvm_use_linker \
				# RUN: -DPython3_EXECUTABLE=%python
	# RUN: %cmake_exe --build . --target check-standalone \| tee %t \| FileCheck %s			# RUN: %cmake_exe --build . --target check-standalone \| tee %t \| FileCheck %s

	# Note: The number of checked tests is not important. The command will fail			# Note: The number of checked tests is not important. The command will fail
	# if any fail.			# if any fail.
	# CHECK: Passed			# CHECK: Passed
	# UNSUPPORTED: windows, android			# UNSUPPORTED: windows, android