This is an archive of the discontinued LLVM Phabricator instance.

[RISCV] Make computeIncomingVLVTYPE more conservative when merging predecessor state.
ClosedPublic

Authored by craig.topper on Sep 19 2022, 2:59 PM.

Details

Summary

If we have already calculated the incoming state before, use that
as our starting point to ensure we are conservative.

Diff Detail

Event Timeline

craig.topper created this revision.Sep 19 2022, 2:59 PM
craig.topper requested review of this revision.Sep 19 2022, 2:59 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 19 2022, 2:59 PM
reames accepted this revision.Sep 19 2022, 3:03 PM

LGTM

For context, Craig and I debugged this earlier today. We had an infinite loop issue which came down to the fact we allowed two waves of updates to propagate through a loop, and the merge points allowed us to toggle back and forth between states instead of falling to the bottom value of the lattice. No known small reproducer at this time unfortunately.

This revision is now accepted and ready to land.Sep 19 2022, 3:03 PM
This revision was landed with ongoing or failed builds.Sep 19 2022, 3:58 PM
This revision was automatically updated to reflect the committed changes.