Write semantics test for FORM-TEAM statement.

[hussainjk]

Summary

Write semantics tests for the FORM TEAM statement.

[ktras]

The tests look great! Please see my inline comments for some suggestions. Also, I see that you are checking to make sure that type mismatches for the team-number, team-variable and the specifiers in the form-team-spec-list are caught, which is great. Since all of these are supposed to be scalar, what about checking that rank mismatches for team-number, team-variable and the specifiers are not allowed?

flang/test/Semantics/form_team01.f90

35

36

If it is your intention to have new_index be coindexed, the coarray reference needs to include an image-selector. See the suggested edit. For the image-selector, you can of course put a this_image() call or pick a different integer literal than the one I included in my suggested edit.

flang/test/Semantics/form_team01b.f90

16

See comment above about coindexing.

19

See comment above about coindexing.

[hussainjk]

Addressing review comments.

[hussainjk]

In D134205#3804483, @ktras wrote:

The tests look great! Please see my inline comments for some suggestions. Also, I see that you are checking to make sure that type mismatches for the team-number, team-variable and the specifiers in the form-team-spec-list are caught, which is great. Since all of these are supposed to be scalar, what about checking that rank mismatches for team-number, team-variable and the specifiers are not allowed?

Addressed the comments and added the rank mismatch suggestions.

[ktras]

LGTM.

Do you have commit permissions? Or do you need someone to commit on your behalf?

[hussainjk]

In D134205#3822515, @ktras wrote:

LGTM.

Do you have commit permissions? Or do you need someone to commit on your behalf?

The latter, please.

[ktras]

Okay, sounds great. I will commit this on your behalf.

flang/test/Semantics/form_team01.f90

+! RUN: %python %S/test_errors.py %s %flang_fc1
+! Check for semantic errors in form team statements
+
+subroutine test
+  use, intrinsic :: iso_fortran_env, only: team_type
+  type(team_type) :: team
+  integer :: team_number
+  integer :: team_index
+  integer :: statvar
+  character(len=50) :: errvar
+  integer, codimension[*] :: co_team_number
+  integer, codimension[*] :: co_team_index
+  logical :: invalid_argument
+
+  ! Valid invocations which should produce no errors.
+  FORM TEAM (team_number, team)
+  ! One form-team-spec argument.
+  FORM TEAM (team_number, team, NEW_INDEX=team_index)
+  FORM TEAM (team_number, team, STAT=statvar)
+  FORM TEAM (team_number, team, ERRMSG=errvar)
+  ! Two form-team-spec arguments in any order.
+  FORM TEAM (team_number, team, NEW_INDEX=team_index, STAT=statvar)
+  FORM TEAM (team_number, team, STAT=statvar, NEW_INDEX=team_index)
+  FORM TEAM (team_number, team, NEW_INDEX=team_index, ERRMSG=errvar)
+  FORM TEAM (team_number, team, ERRMSG=errvar, NEW_INDEX=team_index)
+  FORM TEAM (team_number, team, STAT=statvar, ERRMSG=errvar)
+  FORM TEAM (team_number, team, ERRMSG=errvar, STAT=statvar)
+! Three form-team-spec arguments in any order.
+  FORM TEAM (team_number, team, NEW_INDEX=team_index, STAT=statvar, ERRMSG=errvar) ! identity
+  FORM TEAM (team_number, team, STAT=statvar, NEW_INDEX=team_index, ERRMSG=errvar) ! transposition (1,2)
+  FORM TEAM (team_number, team, ERRMSG=errvar, STAT=statvar, NEW_INDEX=team_index) ! transposition (1,3)
+  FORM TEAM (team_number, team, NEW_INDEX=team_index, ERRMSG=errvar, STAT=statvar) ! transposition (2,3)
+  FORM TEAM (team_number, team, ERRMSG=errvar, NEW_INDEX=team_index, STAT=statvar) ! cycle (1,2,3)
+  FORM TEAM (team_number, team, STAT=statvar, ERRMSG=errvar, NEW_INDEX=team_index) ! cycle (1,3,2)
+  ! It is semantically legal for team_index to be coindexed.
+  FORM TEAM (team_number, team, NEW_INDEX=co_team_index)
+
+  ! Semantically invalid invocations.
+  !ERROR: Must have INTEGER type, but is LOGICAL(4)
+  FORM TEAM (invalid_argument, team)
+  !ERROR: Must have INTEGER type, but is REAL(4)
+  FORM TEAM (0.0, team)
+  !ERROR: Must have INTEGER type, but is REAL(4)
+  FORM TEAM (team_number, team, NEW_INDEX=0.0)
+  !ERROR: Must have INTEGER type, but is LOGICAL(4)
+  FORM TEAM (team_number, team, STAT=invalid_argument)
+  !ERROR: Must have CHARACTER type, but is LOGICAL(4)
+  FORM TEAM (team_number, team, ERRMSG=invalid_argument)
+
+end subroutine

flang/test/Semantics/form_team01a.f90

+! RUN: %python %S/test_errors.py %s %flang_fc1
+! Check for semantic errors in form team statements
+! This subtest contains syntactic tests that prevent the main tests from being emitted.
+
+subroutine test
+  use, intrinsic :: iso_fortran_env, only: team_type
+  type(team_type) :: team
+  integer :: team_number
+
+  ! Syntactically invalid invocations.
+  !ERROR: expected '('
+  FORM TEAM (team_number, 0)
+  !ERROR: expected '('
+  FORM TEAM (team_number, team, STAT=0)
+  !ERROR: expected '('
+  FORM TEAM (team_number, team, ERRMSG='')
+end subroutine

flang/test/Semantics/form_team01b.f90

+! RUN: %python %S/test_errors.py %s %flang_fc1
+! XFAIL: *
+! Check for semantic errors in form team statements
+! This subtest contains tests for unimplemented errors.
+
+subroutine test
+  use, intrinsic :: iso_fortran_env, only: team_type
+  type(team_type) :: team
+  integer :: team_number
+  integer, codimension[*] :: co_statvar
+  character(len=50), codimension[*] :: co_errvar
+
+  ! Semantically invalid invocations.
+  ! argument 'stat' shall not be a coindexed object
+  !ERROR: to be determined
+  FORM TEAM (team_number, team, STAT=co_statvar)
+  ! argument 'errmsg' shall not be a coindexed object
+  !ERROR: to be determined
+  FORM TEAM (team_number, team, ERRMSG=co_errvar)
+
+end subroutine