This is an archive of the discontinued LLVM Phabricator instance.

Differential D134205

Write semantics test for FORM-TEAM statement.
ClosedPublic

Authored by hussainjk on Sep 19 2022, 11:56 AM.

Details

Reviewers
rouson
ktras
pmccormick
sscalpone
Commits
rG5e7c6894408e: [flang] Write semantics tests for the FORM TEAM statement.
Summary

Write semantics tests for the FORM TEAM statement.

Diff Detail

Event Timeline

hussainjk created this revision.Sep 19 2022, 11:56 AM
Herald added a reviewer: sscalpone. · View Herald TranscriptSep 19 2022, 11:56 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald Transcript
hussainjk requested review of this revision.Sep 19 2022, 11:56 AM
Herald added a subscriber: jdoerfert. · View Herald TranscriptSep 19 2022, 11:56 AM
Harbormaster completed remote builds in B187544: Diff 461291.Sep 19 2022, 12:29 PM
ktras added a comment.Sep 20 2022, 4:29 PM

The tests look great! Please see my inline comments for some suggestions. Also, I see that you are checking to make sure that type mismatches for the team-number, team-variable and the specifiers in the form-team-spec-list are caught, which is great. Since all of these are supposed to be scalar, what about checking that rank mismatches for team-number, team-variable and the specifiers are not allowed?

flang/test/Semantics/form_team01.f90
36
37

If it is your intention to have new_index be coindexed, the coarray reference needs to include an image-selector. See the suggested edit. For the image-selector, you can of course put a this_image() call or pick a different integer literal than the one I included in my suggested edit.

flang/test/Semantics/form_team01b.f90
17

See comment above about coindexing.

20

See comment above about coindexing.

hussainjk updated this revision to Diff 463576.Sep 28 2022, 8:47 AM

Addressing review comments.

hussainjk added a comment.Sep 28 2022, 8:49 AM
In D134205#3804483, @ktras wrote:

The tests look great! Please see my inline comments for some suggestions. Also, I see that you are checking to make sure that type mismatches for the team-number, team-variable and the specifiers in the form-team-spec-list are caught, which is great. Since all of these are supposed to be scalar, what about checking that rank mismatches for team-number, team-variable and the specifiers are not allowed?

Addressed the comments and added the rank mismatch suggestions.

Harbormaster completed remote builds in B189190: Diff 463576.Sep 28 2022, 9:20 AM
ktras accepted this revision.Sep 28 2022, 5:35 PM

LGTM.

Do you have commit permissions? Or do you need someone to commit on your behalf?

This revision is now accepted and ready to land.Sep 28 2022, 5:35 PM
hussainjk added a comment.Oct 3 2022, 8:35 AM
In D134205#3822515, @ktras wrote:

LGTM.

Do you have commit permissions? Or do you need someone to commit on your behalf?

The latter, please.

ktras added a comment.Oct 3 2022, 8:49 AM

Okay, sounds great. I will commit this on your behalf.

Closed by commit rG5e7c6894408e: [flang] Write semantics tests for the FORM TEAM statement. (authored by hussainjk, committed by ktras). · Explain WhyOct 3 2022, 11:47 AM
This revision was automatically updated to reflect the committed changes.
ktras added a commit: rG5e7c6894408e: [flang] Write semantics tests for the FORM TEAM statement..

Revision Contents

PathSize
flang/
test/
Semantics/
67 lines
17 lines
21 lines

Diff 464754

flang/test/Semantics/form_team01.f90

  • This file was added.
! RUN: %python %S/test_errors.py %s %flang_fc1
! Check for semantic errors in form team statements
subroutine test
use, intrinsic :: iso_fortran_env, only: team_type
type(team_type) :: team
integer :: team_number
integer :: team_index
integer :: statvar
character(len=50) :: errvar
integer, codimension[*] :: co_team_number
integer, codimension[*] :: co_team_index
type(team_type), dimension(1) :: array_team
integer, dimension(1) :: array_team_number
integer, dimension(1) :: array_team_index
integer, dimension(1) :: array_statvar
character(len=50), dimension(1) :: array_errvar
logical :: invalid_argument
! Valid invocations which should produce no errors.
FORM TEAM (team_number, team)
! One form-team-spec argument.
FORM TEAM (team_number, team, NEW_INDEX=team_index)
FORM TEAM (team_number, team, STAT=statvar)
FORM TEAM (team_number, team, ERRMSG=errvar)
! Two form-team-spec arguments in any order.
FORM TEAM (team_number, team, NEW_INDEX=team_index, STAT=statvar)
FORM TEAM (team_number, team, STAT=statvar, NEW_INDEX=team_index)
FORM TEAM (team_number, team, NEW_INDEX=team_index, ERRMSG=errvar)
FORM TEAM (team_number, team, ERRMSG=errvar, NEW_INDEX=team_index)
FORM TEAM (team_number, team, STAT=statvar, ERRMSG=errvar)
FORM TEAM (team_number, team, ERRMSG=errvar, STAT=statvar)
! Three form-team-spec arguments in any order.
FORM TEAM (team_number, team, NEW_INDEX=team_index, STAT=statvar, ERRMSG=errvar) ! identity
FORM TEAM (team_number, team, STAT=statvar, NEW_INDEX=team_index, ERRMSG=errvar) ! transposition (1,2)
ktrasUnsubmitted
Not Done
ReplyInline Actions
FORM TEAM (team_number, team, STAT=statvar, ERRMSG=errvar, NEW_INDEX=team_index) ! cycle (1,3,2)
- ! It is semantically legal for team_index to be coindexed.
+ ! It is semantically legal for new_index to be coindexed.
FORM TEAM (team_number, team, NEW_INDEX=co_team_index)
ktras:
FORM TEAM (team_number, team, ERRMSG=errvar, STAT=statvar, NEW_INDEX=team_index) ! transposition (1,3)
ktrasUnsubmitted
Not Done
ReplyInline Actions
! It is semantically legal for team_index to be coindexed.
- FORM TEAM (team_number, team, NEW_INDEX=co_team_index)
+ FORM TEAM (team_number, team, NEW_INDEX=co_team_index[1])
! Semantically invalid invocations.

If it is your intention to have new_index be coindexed, the coarray reference needs to include an image-selector. See the suggested edit. For the image-selector, you can of course put a this_image() call or pick a different integer literal than the one I included in my suggested edit.

ktras: If it is your intention to have `new_index` be coindexed, the coarray reference needs to…
FORM TEAM (team_number, team, NEW_INDEX=team_index, ERRMSG=errvar, STAT=statvar) ! transposition (2,3)
FORM TEAM (team_number, team, ERRMSG=errvar, NEW_INDEX=team_index, STAT=statvar) ! cycle (1,2,3)
FORM TEAM (team_number, team, STAT=statvar, ERRMSG=errvar, NEW_INDEX=team_index) ! cycle (1,3,2)
! It is semantically legal for team_index to be coindexed.
FORM TEAM (team_number, team, NEW_INDEX=co_team_index[this_image()])
! Semantically invalid invocations.
!ERROR: Must have INTEGER type, but is LOGICAL(4)
FORM TEAM (invalid_argument, team)
!ERROR: Must have INTEGER type, but is REAL(4)
FORM TEAM (0.0, team)
!ERROR: Must have INTEGER type, but is LOGICAL(4)
FORM TEAM (team_number, team, NEW_INDEX=invalid_argument)
!ERROR: Must have INTEGER type, but is LOGICAL(4)
FORM TEAM (team_number, team, STAT=invalid_argument)
!ERROR: Must have CHARACTER type, but is LOGICAL(4)
FORM TEAM (team_number, team, ERRMSG=invalid_argument)
! Arguments with rank mismatches.
!ERROR: Must be a scalar value, but is a rank-1 array
FORM TEAM (array_team_number, team)
!ERROR: Must be a scalar value, but is a rank-1 array
FORM TEAM (team_number, array_team)
!ERROR: Must be a scalar value, but is a rank-1 array
FORM TEAM (team_number, team, NEW_INDEX=array_team_index)
!ERROR: Must be a scalar value, but is a rank-1 array
FORM TEAM (team_number, team, STAT=array_statvar)
!ERROR: Must be a scalar value, but is a rank-1 array
FORM TEAM (team_number, team, ERRMSG=array_errvar)
end subroutine

flang/test/Semantics/form_team01a.f90

  • This file was added.
! RUN: %python %S/test_errors.py %s %flang_fc1
! Check for semantic errors in form team statements
! This subtest contains syntactic tests that prevent the main tests from being emitted.
subroutine test
use, intrinsic :: iso_fortran_env, only: team_type
type(team_type) :: team
integer :: team_number
! Syntactically invalid invocations.
!ERROR: expected '('
FORM TEAM (team_number, 0)
!ERROR: expected '('
FORM TEAM (team_number, team, STAT=0)
!ERROR: expected '('
FORM TEAM (team_number, team, ERRMSG='')
end subroutine

flang/test/Semantics/form_team01b.f90

  • This file was added.
! RUN: %python %S/test_errors.py %s %flang_fc1
! XFAIL: *
! Check for semantic errors in form team statements
! This subtest contains tests for unimplemented errors.
subroutine test
use, intrinsic :: iso_fortran_env, only: team_type
type(team_type) :: team
integer :: team_number
integer, codimension[*] :: co_statvar
character(len=50), codimension[*] :: co_errvar
! Semantically invalid invocations.
! argument 'stat' shall not be a coindexed object
!ERROR: to be determined
FORM TEAM (team_number, team, STAT=co_statvar[this_image()])
! argument 'errmsg' shall not be a coindexed object
ktrasUnsubmitted
Not Done
ReplyInline Actions
!ERROR: to be determined
- FORM TEAM (team_number, team, STAT=co_statvar)
+ FORM TEAM (team_number, team, STAT=co_statvar[1])
! argument 'errmsg' shall not be a coindexed object

See comment above about coindexing.

ktras: See comment above about coindexing.
!ERROR: to be determined
FORM TEAM (team_number, team, ERRMSG=co_errvar[this_image()])
ktrasUnsubmitted
Not Done
ReplyInline Actions
!ERROR: to be determined
- FORM TEAM (team_number, team, ERRMSG=co_errvar)
+ FORM TEAM (team_number, team, ERRMSG=co_errvar[1])
end subroutine

See comment above about coindexing.

ktras: See comment above about coindexing.
end subroutine