[AVR] Fix useDeprecatedPositionallyEncodedOperands errors.

[jyknight]

Summary

This is a follow-on to https://reviews.llvm.org/D134073.

It renames a few fields to have consistent names, as well as renaming
operands to match the field names.

The encoder behavior is unchanged by this cleanup, but a few
instructions were previously being disassembled incorrectly, and have
been corrected by this change. All of the affected instructions were
missing disassembly tests, which are now added.

[MaskRay]

Thanks!

llvm/test/MC/AVR/inst-rjmp.s

36

This can use INST-COUNT-8:

llvm/test/MC/AVR/inst-sbrs.s

2

< %s => %s

[benshi001]

this is non functional change, it would be better to retitled to [NFC][AVR] Fix useDeprecatedPositionallyEncodedOperands errors.

[jyknight]

this is non functional change, it would be better to retitled to [NFC][AVR] Fix useDeprecatedPositionallyEncodedOperands errors.

It is not; it fixes bugs in the disassembler as noted in the change description.

[benshi001]

Thanks.

[jyknight]

llvm/test/MC/AVR/inst-rjmp.s

36

I'd rather not, just for clarity.

llvm/test/MC/AVR/inst-sbrs.s

2

Any particular reason? Most such tests (e.g. the line above) seem to use < %s currently.