This is an archive of the discontinued LLVM Phabricator instance.

[mlir] [docs] Broken link in MLIR Toy docs

Authored by Wheest on Sep 15 2022, 2:15 PM.



In the Ch6 of the Toy Example for MLIR, there is a broken link. If ones goes to the page for Chapter 6, and click on the link "Conversion to the LLVM IR Dialect", one will see it takes you to a page that no longer exists.

I believe this should actually be this link.

Note to reviewers that this is my first submitted patch to LLVM, and using the phabricator system, so there is a higher risk that I have made an error, and brief feedback on these patch notes would be appreciated.

Reviewer rational: Users who git blame say contributed to the tutorial.

I believe that automated tests on these markdown docs could reduce the risk of this kind of error occurring again. For example, this Python package checks for broken markdown links. However, I am unsure where in the existing testing infrastructure this could go, I am only somewhat familiar with the C++ side.

Diff Detail

Event Timeline

Wheest created this revision.Sep 15 2022, 2:15 PM
Wheest requested review of this revision.Sep 15 2022, 2:15 PM
Mogball accepted this revision.Sep 15 2022, 2:22 PM
This revision is now accepted and ready to land.Sep 15 2022, 2:22 PM

Thanks, if the reviewers are happy, then I request that this gets pushed.

I don't think I have commit access, in which case, my preferred git author line would be Perry Gibson <>.

This revision was automatically updated to reflect the committed changes.