This is an archive of the discontinued LLVM Phabricator instance.

[llvm-lipo] Support object files with bitcode asm
ClosedPublic

Authored by thevinster on Sep 12 2022, 2:52 PM.

Details

Summary

llvm-lipo crashes when trying to use inputs that contain bitcode asm instructions.
This happens when trying to create universal binaries for LLVM with LTO.
https://reviews.llvm.org/D118575 is a similar change that ran into this same issue, and I'm
mirroring the same change by registering the targets to fix this issue.

Diff Detail

Unit TestsFailed

Event Timeline

thevinster created this revision.Sep 12 2022, 2:52 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 12 2022, 2:52 PM
Herald added a subscriber: ormris. · View Herald Transcript
thevinster retitled this revision from [llvm-lipo] Support object files with asm to [llvm-lipo] Support object files with bitcode asm.Sep 12 2022, 3:11 PM
thevinster edited the summary of this revision. (Show Details)
thevinster published this revision for review.Sep 12 2022, 3:17 PM
thevinster edited the summary of this revision. (Show Details)
Herald added a project: Restricted Project. · View Herald TranscriptSep 12 2022, 3:17 PM
keith accepted this revision.Sep 12 2022, 3:26 PM
This revision is now accepted and ready to land.Sep 12 2022, 3:26 PM
This revision was landed with ongoing or failed builds.Sep 12 2022, 6:14 PM
This revision was automatically updated to reflect the committed changes.