[llvm-lipo] Support object files with bitcode asm
ClosedPublic
Actions

Authored by thevinster on Sep 12 2022, 2:52 PM.

Details

Reviewers

smeenai
alexander-shaposhnikov
keith
mtrent

Commits

rG61e54384982a: [llvm-lipo] Support object files with bitcode asm

Summary

llvm-lipo crashes when trying to use inputs that contain bitcode asm instructions.
This happens when trying to create universal binaries for LLVM with LTO.
https://reviews.llvm.org/D118575 is a similar change that ran into this same issue, and I'm
mirroring the same change by registering the targets to fix this issue.

Diff Detail

Repository: rG LLVM Github Monorepo

Unit TestsFailed
View All

	Time	Test
	60,100 ms	x64 debian > MLIR.Examples/standalone::test.toy Script: -- : 'RUN: at line 1'; /usr/bin/cmake /var/lib/buildkite-agent/builds/llvm-project/mlir/examples/standalone -G "Ninja" -DCMAKE_CXX_COMPILER=/usr/bin/clang++ -DCMAKE_C_COMPILER=/usr/bin/clang -DLLVM_ENABLE_LIBCXX=OFF -DMLIR_DIR=/var/lib/buildkite-agent/builds/llvm-project/build/lib/cmake/mlir -DLLVM_USE_LINKER=lld

Event Timeline

thevinster created this revision.Sep 12 2022, 2:52 PM

Herald added a project: Restricted Project. · View Herald TranscriptSep 12 2022, 2:52 PM

Herald added a subscriber: ormris. · View Herald Transcript

thevinster retitled this revision from [llvm-lipo] Support object files with asm to [llvm-lipo] Support object files with bitcode asm.Sep 12 2022, 3:11 PM

thevinster edited the summary of this revision. (Show Details)

thevinster added reviewers: smeenai, alexander-shaposhnikov, keith, mtrent.

thevinster published this revision for review.Sep 12 2022, 3:17 PM

thevinster edited the summary of this revision. (Show Details)

Herald added a project: Restricted Project. · View Herald TranscriptSep 12 2022, 3:17 PM

Herald added a subscriber: llvm-commits. · View Herald Transcript

keith accepted this revision.Sep 12 2022, 3:26 PM

This revision is now accepted and ready to land.Sep 12 2022, 3:26 PM

Harbormaster completed remote builds in B186235: Diff 459566.Sep 12 2022, 3:42 PM

LGTM

This revision was landed with ongoing or failed builds.Sep 12 2022, 6:14 PM

Closed by commit rG61e54384982a: [llvm-lipo] Support object files with bitcode asm (authored by thevinster). · Explain Why