This is an archive of the discontinued LLVM Phabricator instance.

[clangd] Improve Selection testcase, pin to C++17

Authored by sammccall on Sep 7 2022, 7:00 AM.



17 vs 14 have different ASTs, this causes D131465 to have to touch this test.
While here, make sure we're being clear about *which* nodes we're matching.

Diff Detail

Event Timeline

sammccall created this revision.Sep 7 2022, 7:00 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 7 2022, 7:00 AM
Herald added a subscriber: arphaman. · View Herald Transcript
sammccall requested review of this revision.Sep 7 2022, 7:00 AM
kadircet accepted this revision.Sep 7 2022, 7:21 AM

can you wait for premerge checks to finish (especially for windows)?

This revision is now accepted and ready to land.Sep 7 2022, 7:21 AM
This revision was automatically updated to reflect the committed changes.