[lldb] Fix SBFileSpec.fullpath for Windows

[kastiglione]

Summary

Fix fullpath to not assume a / path separator. This was discovered when
D133130 failed on Windows. Use os.path.join() to fix the issue.

[kastiglione]

will add a test before committing, there was no immediately obvious place for a test.

[mib]

LGTM!

[kastiglione]

Add a test

[stella.stamenova]

This broke the Windows lldb bot: https://lab.llvm.org/buildbot/#/builders/83/builds/25854

[kastiglione]

@stella.stamenova fix about to be committed.

[kastiglione]

@stella.stamenova fix is rG1ee299a57d0b5f49b6c37d81474ea030e3b122de

[kastiglione]

@stella.stamenova I realized that test has more paths that need fixing. The rest are fixed in rG760c75fe2d25e06644271cb1338f8b0f8d9abc70.

[kastiglione]

Ugh, the test that is failing uses windows paths but runs on both windows and non-windows machines. I will revert this and the two fix commits.

[kastiglione]

Reverted in rG01f924d0e37a5deae51df0d77e10a15b63aa0c0f

[stella.stamenova]

In D133366#3923291, @kastiglione wrote:

Ugh, the test that is failing uses windows paths but runs on both windows and non-windows machines. I will revert this and the two fix commits.

You should be able to test for the operating system and set the paths accordingly in the test.

[kastiglione]

I will do that and recommit, thanks.

[labath]

The real problem here is that the __get_fullpath__ implementation does not use the path style information from within the FileSpec object. Hardcoding it to use the host os path style (instead of posix style) just changes the set of bugs.

[kastiglione]

@labath thanks, I believe a more correct fix here https://reviews.llvm.org/D138348

lldb/bindings/interface/SBFileSpec.i

public:
     STRING_EXTENSION(SBFileSpec)
 
 #ifdef SWIGPYTHON
     %pythoncode %{
         def __get_fullpath__(self):
             spec_dir = self.GetDirectory()
             spec_file = self.GetFilename()
             if spec_dir and spec_file:
-                return '%s/%s' % (spec_dir, spec_file)
+                return os.path.join(spec_dir, spec_file)
             elif spec_dir:
                 return spec_dir
             elif spec_file:
                 return spec_file
             return None
 
         fullpath = property(__get_fullpath__, None, doc='''A read only property that returns the fullpath as a python string.''')
         basename = property(GetFilename, None, doc='''A read only property that returns the path basename as a python string.''')
         dirname = property(GetDirectory, None, doc='''A read only property that returns the path directory name as a python string.''')
         exists = property(Exists, None, doc='''A read only property that returns a boolean value that indicates if the file exists.''')
     %}
 #endif
 
 };
 
 } // namespace lldb