[lldb] Fix SBFileSpec.fullpath

[kastiglione]

Summary

Reimplement SBFileSpec.fullpath to (indirectly) use FileSpec::GetPath.

Instead of hardcoding a / separator, use GetPath. This makes use of the FileSpec's internal style, which for example allows for backslash on Windows where required.

It's not obvious from looking at the source, but the fullpath property is implemented with str, which calls GetDescription, which in finally calls GetPath.

[kastiglione]

Fix commit wording

[labath]

cool

lldb/bindings/interface/SBFileSpec.i

public:
 
     void
     AppendPathComponent (const char *file_or_directory);
 
     STRING_EXTENSION(SBFileSpec)
 
 #ifdef SWIGPYTHON
     %pythoncode %{
-        def __get_fullpath__(self):
-            spec_dir = self.GetDirectory()
-            spec_file = self.GetFilename()
-            if spec_dir and spec_file:
-                return '%s/%s' % (spec_dir, spec_file)
-            elif spec_dir:
-                return spec_dir
-            elif spec_file:
-                return spec_file
-            return None
-
-        fullpath = property(__get_fullpath__, None, doc='''A read only property that returns the fullpath as a python string.''')
+        fullpath = property(str, None, doc='''A read only property that returns the fullpath as a python string.''')
         basename = property(GetFilename, None, doc='''A read only property that returns the path basename as a python string.''')
         dirname = property(GetDirectory, None, doc='''A read only property that returns the path directory name as a python string.''')
         exists = property(Exists, None, doc='''A read only property that returns a boolean value that indicates if the file exists.''')
     %}
 #endif
 
 };
 
 } // namespace lldb