Page MenuHomePhabricator

[RFC][OpenMP][Offloading] dlopen plugins with version
Needs ReviewPublic

Authored by tianshilei1992 on Sep 4 2022, 12:08 PM.

Details

Summary

Currently we open a plugin using its name such as libomptarget.rtl.cuda.so. We
don't verify its version, and always assume the backward compatibility, by
restricting changes of the plugin interfaces. Since LLVM 15, we made the plugin
a LLVM library, which means now it has version, because LLVM libraries are not
guaranteed backward compatible among major versions. Given that fact, in this
patch, we load a plugin w/ version in its name. This could at least prevent the
problem caused by incompatible LLVM components.

Diff Detail

Event Timeline

tianshilei1992 created this revision.Sep 4 2022, 12:08 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 4 2022, 12:08 PM
tianshilei1992 requested review of this revision.Sep 4 2022, 12:08 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 4 2022, 12:08 PM

That can land now that we agreed on no major version compatibility right.