This is an archive of the discontinued LLVM Phabricator instance.

[mlir][sparse] extend codegen test cases with an additional step after storage expansion
ClosedPublic

Authored by Peiming on Sep 2 2022, 11:07 AM.

Diff Detail

Event Timeline

Peiming created this revision.Sep 2 2022, 11:07 AM
Herald added a project: Restricted Project. · View Herald Transcript
Peiming requested review of this revision.Sep 2 2022, 11:07 AM
aartbik accepted this revision.Sep 2 2022, 11:20 AM

Nice! One nit, but good to go in (after dep revision of course)

mlir/test/Dialect/SparseTensor/codegen.mlir
43

here and below, can you use a // for the empty lines between CODEGEN/STORAGE, so the block as a whole "stays connecedt" with the function

This revision is now accepted and ready to land.Sep 2 2022, 11:20 AM
Peiming updated this revision to Diff 457649.Sep 2 2022, 11:23 AM

Address comments

Peiming marked an inline comment as done.Sep 2 2022, 11:23 AM
This revision was landed with ongoing or failed builds.Sep 2 2022, 11:34 AM
This revision was automatically updated to reflect the committed changes.