This is an archive of the discontinued LLVM Phabricator instance.

[clang-format] [doc] Fix example of wrapping class definitions
ClosedPublic

Authored by Passw on Aug 31 2022, 8:49 PM.

Diff Detail

Event Timeline

Passw created this revision.Aug 31 2022, 8:49 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 31 2022, 8:49 PM
Passw requested review of this revision.Aug 31 2022, 8:49 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 31 2022, 8:49 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Passw added a project: Restricted Project.
HazardyKnusperkeks retitled this revision from [Docs] fix wrong example of warping class definitions to [clang-format][NFC][Docs] fix wrong example of warping class definitions.Sep 1 2022, 12:26 PM

You have to make the change in the Format.h and run clang/docs/tools/dump_format_style.py which generates the rst.

Passw updated this revision to Diff 457438.Sep 1 2022, 4:20 PM

modify Foramt.h and generate ClangFormatStyleOptions.rst by running dump_format_style.py

MyDeveloperDay accepted this revision.Sep 2 2022, 3:30 AM
This revision is now accepted and ready to land.Sep 2 2022, 3:30 AM
owenpan accepted this revision.Sep 2 2022, 8:59 PM

LGTM

Passw added a comment.Sep 3 2022, 5:33 PM

I do not have commit access, please help to commit this change.
Thanks.

I do not have commit access, please help to commit this change.
Thanks.

Please state name and email for the commit.

I do not have commit access, please help to commit this change.
Thanks.

Please state a name and email for the commit.

curdeius retitled this revision from [clang-format][NFC][Docs] fix wrong example of warping class definitions to [clang-format] [doc] Fix example of wrapping class definitions.Sep 5 2022, 1:42 AM
curdeius edited the summary of this revision. (Show Details)
Passw added a comment.Sep 5 2022, 6:10 PM

I do not have commit access, please help to commit this change.
Thanks.

Please state a name and email for the commit.

Passw
passw_passw@outlook.com

Just a note, I had to edit your patch. Did you create it with git diff?

Passw added a comment.Sep 6 2022, 6:20 AM

Just a note, I had to edit your patch. Did you create it with git diff?

Yes, I create this patch with git diff according to this guideline Requesting a review via the web interface