This is an archive of the discontinued LLVM Phabricator instance.

[LLDB] Simplify cmake for instruction emulation unit tests
ClosedPublic

Authored by DavidSpickett on Aug 31 2022, 7:49 AM.

Details

Summary

I got suspicious because of checking "ARM" for an "ARM64" plugin.
As far as I can tell these never needed an llvm target to function.

Looking at the corresponding cmake for the libraries under test they
don't reference target libraries either.

Diff Detail

Event Timeline

DavidSpickett created this revision.Aug 31 2022, 7:49 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 31 2022, 7:49 AM
DavidSpickett requested review of this revision.Aug 31 2022, 7:49 AM
labath accepted this revision.Aug 31 2022, 9:37 AM

If the tests work without the corresponding llvm targets, then yea, ship it.

This revision is now accepted and ready to land.Aug 31 2022, 9:37 AM