This is an archive of the discontinued LLVM Phabricator instance.

[mlir][tosa] Fix windows build-bot error due to implicit i64 cast
ClosedPublic

Authored by rsuderman on Aug 30 2022, 12:53 PM.

Details

Summary

There is an implicit i64 cast due to the << during MulOp's folder.

Diff Detail

Event Timeline

rsuderman created this revision.Aug 30 2022, 12:53 PM
Herald added a project: Restricted Project. · View Herald Transcript
rsuderman requested review of this revision.Aug 30 2022, 12:53 PM
rsuderman retitled this revision from BEGIN_PUBLIC [mlir][tosa] Fix windows build-bot error due to implicit i64 cast to [mlir][tosa] Fix windows build-bot error due to implicit i64 cast.Aug 30 2022, 12:53 PM
rsuderman edited the summary of this revision. (Show Details)
NatashaKnk accepted this revision.Aug 30 2022, 12:56 PM
This revision is now accepted and ready to land.Aug 30 2022, 12:56 PM
This revision was landed with ongoing or failed builds.Aug 30 2022, 1:02 PM
This revision was automatically updated to reflect the committed changes.

It looks like this was not enough and you'll need an explicit cast. There's also a second one a few lines down: https://lab.llvm.org/buildbot/#/builders/13/builds/25203/steps/6/logs/stdio

The windows mlir bot is still broken, if we can't get a fix today, I'll go ahead and revert the changes:

https://lab.llvm.org/buildbot/#/builders/13/builds/25203/steps/6/logs/stdio

Generally we prefer to fix forward MSVC compiler errors as the LLVM CI runs a clang build, as many contributors do not have access to windows development machines.