Page MenuHomePhabricator

[amdgpu] Drop multiple calls to hsa_init
Needs ReviewPublic

Authored by JonChesterfield on Aug 30 2022, 12:38 PM.

Details

Summary

Revert likely unintentional part of 4075a811ad99b7

Diff Detail

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptAug 30 2022, 12:38 PM
JonChesterfield requested review of this revision.Aug 30 2022, 12:38 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 30 2022, 12:38 PM
jhuber6 accepted this revision.Aug 30 2022, 6:17 PM
jhuber6 added a subscriber: jhuber6.

Seems HSA is already initialized by the RTLDeviceInfoTy pointer, so this is definitely redundant.

This revision is now accepted and ready to land.Aug 30 2022, 6:17 PM
JonChesterfield added 1 blocking reviewer(s): saiislam.Sep 1 2022, 9:52 AM
This revision now requires review to proceed.Sep 1 2022, 9:52 AM

I think we can not remove this initialization.

Are the following failing tests passing after applying this patch?
https://lab.llvm.org/buildbot/#/builders/193/builds/15846