This is an archive of the discontinued LLVM Phabricator instance.

[SystemZ][z/OS] Account for renamed parameter name (libc++)
ClosedPublic

Authored by muiez on Aug 30 2022, 8:02 AM.

Details

Summary

The following patch (https://reviews.llvm.org/D129051) broke z/OS builds by renaming the parameter name. This patch accounts for that change.

Diff Detail

Event Timeline

muiez created this revision.Aug 30 2022, 8:02 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 30 2022, 8:02 AM
muiez requested review of this revision.Aug 30 2022, 8:02 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 30 2022, 8:02 AM
Herald added 1 blocking reviewer(s): Restricted Project. · View Herald Transcript
philnik accepted this revision.Aug 30 2022, 8:06 AM
philnik added a subscriber: philnik.

Sorry, I didn't see that one. LGTM.

This revision is now accepted and ready to land.Aug 30 2022, 8:06 AM
zibi accepted this revision.Aug 30 2022, 8:29 AM

LGTM

Mordante accepted this revision.Aug 30 2022, 8:59 AM
Mordante added a subscriber: Mordante.

LGTM! Does this need to be backported to the LLVM-15 release branch?

LGTM! Does this need to be backported to the LLVM-15 release branch?

That would be great. Is there a process to do so? Or is it simply cherry-picking to the llvmorg-15.0.0-rc3 release branch.

This revision was automatically updated to reflect the committed changes.

LGTM! Does this need to be backported to the LLVM-15 release branch?

That would be great. Is there a process to do so? Or is it simply cherry-picking to the llvmorg-15.0.0-rc3 release branch.

There is a process. @ldionne is the one to do that. I've already asked him to do it.

This will get cherry-picked via https://github.com/llvm/llvm-project/issues/57491.

Thanks for the heads up @Mordante !