Rename gfx11_asm_vop3p.s to gfx11_asm_vop3p_features.s - they have manually written tests for VOP3P features I do not want to remove.
Add script-generated tests for all VOP3P opcodes.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
LGTM
llvm/test/MC/AMDGPU/gfx11_asm_vop3p.s | ||
---|---|---|
306 | Interesting, I didn't consider you could modify the inline constants. I think only useful case would minus on inline 1/(2*PI), the other constants also have a negative version. |
Comment Actions
llvm/test/MC/AMDGPU/gfx11_asm_vop3p.s | ||
---|---|---|
306 | Actually abs(-1) = 0x7ffffff, it may be useful in some context. I think we can apply input modifiers to inline constants, at least I've never heard that it is prohibited. BTW, SP3 folds abs(-1) to 1! |
Interesting, I didn't consider you could modify the inline constants. I think only useful case would minus on inline 1/(2*PI), the other constants also have a negative version.