This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU][MC][GFX11][NFC] Update asm tests for VOP3P instructions
ClosedPublic

Authored by dp on Aug 29 2022, 11:16 AM.

Details

Summary

Rename gfx11_asm_vop3p.s to gfx11_asm_vop3p_features.s - they have manually written tests for VOP3P features I do not want to remove.
Add script-generated tests for all VOP3P opcodes.

Diff Detail

Event Timeline

dp created this revision.Aug 29 2022, 11:16 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 29 2022, 11:16 AM
dp requested review of this revision.Aug 29 2022, 11:16 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 29 2022, 11:16 AM
Joe_Nash accepted this revision.Aug 29 2022, 11:47 AM

LGTM

llvm/test/MC/AMDGPU/gfx11_asm_vop3p.s
306

Interesting, I didn't consider you could modify the inline constants. I think only useful case would minus on inline 1/(2*PI), the other constants also have a negative version.

This revision is now accepted and ready to land.Aug 29 2022, 11:47 AM
dp added a comment.Aug 29 2022, 12:19 PM
llvm/test/MC/AMDGPU/gfx11_asm_vop3p.s
306

Actually abs(-1) = 0x7ffffff, it may be useful in some context. I think we can apply input modifiers to inline constants, at least I've never heard that it is prohibited. BTW, SP3 folds abs(-1) to 1!

This revision was landed with ongoing or failed builds.Aug 30 2022, 7:05 AM
This revision was automatically updated to reflect the committed changes.