Page MenuHomePhabricator

[clangd] Fail more gracefully if QueryDriverDatabase cannot determine file type
ClosedPublic

Authored by nridge on Aug 29 2022, 1:27 AM.

Details

Summary

Currently, QueryDriverDatabase returns an empty compile command
if it could not determine the file type.

This failure mode is unnecessarily destructive; it's better to
just return the incoming compiler command, which is still more
likely to be useful than an empty command.

Diff Detail

Event Timeline

nridge created this revision.Aug 29 2022, 1:27 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 29 2022, 1:27 AM
Herald added a subscriber: arphaman. · View Herald Transcript
nridge requested review of this revision.Aug 29 2022, 1:27 AM
kadircet accepted this revision.Aug 29 2022, 4:58 AM
This revision is now accepted and ready to land.Aug 29 2022, 4:58 AM