This is an archive of the discontinued LLVM Phabricator instance.

Differential D132778

[BOLT] Change reorder-blocks deprecated option warning output
ClosedPublic

Authored by Amir on Aug 26 2022, 7:10 PM.

Details

Reviewers
rafauler
maksfb
Group Reviewers
Restricted Project
Commits
rG873942e1783f: [BOLT] Change reorder-blocks deprecated option warning output
Summary

Revert to using BOLT-WARNING

Diff Detail

Event Timeline

Amir created this revision.Aug 26 2022, 7:10 PM
Herald added a reviewer: rafauler. · View Herald TranscriptAug 26 2022, 7:10 PM
Herald added a reviewer: maksfb. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: treapster, ayermolo. · View Herald Transcript
Amir requested review of this revision.Aug 26 2022, 7:10 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 26 2022, 7:10 PM
Herald added subscribers: llvm-commits, yota9. · View Herald Transcript
Harbormaster completed remote builds in B183719: Diff 456074.Aug 26 2022, 7:16 PM
maksfb accepted this revision.Sep 8 2022, 11:18 AM
This revision is now accepted and ready to land.Sep 8 2022, 11:18 AM
Closed by commit rG873942e1783f: [BOLT] Change reorder-blocks deprecated option warning output (authored by Amir). · Explain WhySep 8 2022, 3:48 PM
This revision was automatically updated to reflect the committed changes.
Amir added a commit: rG873942e1783f: [BOLT] Change reorder-blocks deprecated option warning output.

Revision Contents

PathSize
bolt/
lib/
Passes/
5 lines

Diff 458903

bolt/lib/Passes/BinaryPasses.cpp

Show First 20 Lines • Show All 172 Lines • ▼ Show 20 Lines cl::values(
"perform layout optimizing I-cache behavior"), "perform layout optimizing I-cache behavior"),
clEnumValN(bolt::ReorderBasicBlocks::LT_OPTIMIZE_EXT_TSP, "ext-tsp", clEnumValN(bolt::ReorderBasicBlocks::LT_OPTIMIZE_EXT_TSP, "ext-tsp",
"perform layout optimizing I-cache behavior"), "perform layout optimizing I-cache behavior"),
clEnumValN(bolt::ReorderBasicBlocks::LT_OPTIMIZE_SHUFFLE, clEnumValN(bolt::ReorderBasicBlocks::LT_OPTIMIZE_SHUFFLE,
"cluster-shuffle", "perform random layout of clusters")), "cluster-shuffle", "perform random layout of clusters")),
cl::ZeroOrMore, cl::cat(BoltOptCategory), cl::ZeroOrMore, cl::cat(BoltOptCategory),
cl::callback([](const bolt::ReorderBasicBlocks::LayoutType &option) { cl::callback([](const bolt::ReorderBasicBlocks::LayoutType &option) {
if (option == bolt::ReorderBasicBlocks::LT_OPTIMIZE_CACHE_PLUS) { if (option == bolt::ReorderBasicBlocks::LT_OPTIMIZE_CACHE_PLUS) {
WithColor::warning() errs() << "BOLT-WARNING: '-reorder-blocks=cache+' is deprecated, please"
<< "'-reorder-blocks=cache+' is deprecated, " << " use '-reorder-blocks=ext-tsp' instead\n";
<< "please use '-reorder-blocks=ext-tsp' instead\n";
ReorderBlocks = bolt::ReorderBasicBlocks::LT_OPTIMIZE_EXT_TSP; ReorderBlocks = bolt::ReorderBasicBlocks::LT_OPTIMIZE_EXT_TSP;
} }
})); }));
static cl::opt<unsigned> ReportBadLayout( static cl::opt<unsigned> ReportBadLayout(
"report-bad-layout", "report-bad-layout",
cl::desc("print top <uint> functions with suboptimal code layout on input"), cl::desc("print top <uint> functions with suboptimal code layout on input"),
cl::init(0), cl::Hidden, cl::cat(BoltOptCategory)); cl::init(0), cl::Hidden, cl::cat(BoltOptCategory));
▲ Show 20 Lines • Show All 1,655 Lines • Show Last 20 Lines