Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp | ||
---|---|---|
2979 | Hello. I don't have that many e's in my name, but I presume you meant me :) This table acts upon legal types, through LT.second in the call to CostTableLookup. That means a v2i16 will be treated as a v2i32 (extending the i16's into the upper halves of each of the i32's), and should see a low cost of 1 because of it. If you think the costs are wrong and need adjusting, they might need to be handled separately from this table. |
Hello - the updates for the comments and the new tests sound OK. I'm not sure if I'm misunderstanding and there is something else you want to propose, but these changes LGTM.
This should probably have had NFC in the title, and ended up being quite different to the version that was reviewed. We have tried not to format the tables in the past because it just creates a worse table (and obscures git-blame). I've tried to clean up the code again a little in 3875c38adf40.
Why not set the scene for N X Ty < 64?
eg: {TTI::SK_Reverse, MVT::v2i16, 1}
@david Greene