This is an archive of the discontinued LLVM Phabricator instance.

Differential D132711

[HLSL] add sqrt library function
ClosedPublic

Authored by bob80905 on Aug 25 2022, 5:21 PM.

Details

Reviewers
beanz
pow2clk
Commits
rGb95c57444a8a: [HLSL] add sqrt library function
Summary

This change exposes the sqrt library function for HLSL scalar types,
excluding long and long long doubles. Sqrt is supported for all scalar, vector,
and matrix types. This patch only adds a subset of scalar type support.

Long and long long double support is missing in this patch because that type
doesn't exist in HLSL.

The full documentation of the HLSL asin function is available here:
https://docs.microsoft.com/en-us/windows/win32/direct3dhlsl/dx-graphics-hlsl-sqrt

Diff Detail

Event Timeline

bob80905 created this revision.Aug 25 2022, 5:21 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 25 2022, 5:21 PM
Herald added a subscriber: Anastasia. · View Herald Transcript
bob80905 requested review of this revision.Aug 25 2022, 5:21 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 25 2022, 5:21 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Harbormaster completed remote builds in B183498: Diff 455767.Aug 25 2022, 6:00 PM
pow2clk added a comment.Aug 26 2022, 3:17 PM

A very minor suggestion. This looks pretty straightforward.

clang/test/CodeGenHLSL/builtins/sqrt.hlsl
6

The -fnative-half-type suggests that you're readying this for when 16-bit types are available. That's fine, but in the spirit of starting as early as possible as we tend to do with these, you might want to target shadermodel6.2 instead since that's where they were introduced and sqrt is as old as HLSL 1.0 AFAIK.

bob80905 updated this revision to Diff 458513.Sep 7 2022, 10:45 AM

Shader Model target update
Change the shader model target to 6.2, because that is when fnative-half-type was introduced.

Harbormaster completed remote builds in B185455: Diff 458513.Sep 7 2022, 10:46 AM
bob80905 updated this revision to Diff 461405.Sep 19 2022, 4:18 PM

rebase
rebasing review to latest origin/main.

Harbormaster completed remote builds in B187630: Diff 461405.Sep 19 2022, 4:19 PM
bob80905 updated this revision to Diff 461636.Sep 20 2022, 11:24 AM

include both commits

Harbormaster completed remote builds in B187787: Diff 461636.Sep 20 2022, 11:24 AM
bob80905 updated this revision to Diff 461638.Sep 20 2022, 11:30 AM

add hlslintr.h file

Harbormaster completed remote builds in B187788: Diff 461638.Sep 20 2022, 11:31 AM
bob80905 updated this revision to Diff 461656.Sep 20 2022, 12:16 PM

Include previous commit

beanz accepted this revision.Sep 20 2022, 12:41 PM

LGTM

This revision is now accepted and ready to land.Sep 20 2022, 12:41 PM
Harbormaster completed remote builds in B187804: Diff 461656.Sep 20 2022, 12:53 PM
bob80905 updated this revision to Diff 461674.Sep 20 2022, 1:17 PM
  • add empty line to end of file sqrt.hlsl
This revision was landed with ongoing or failed builds.Sep 20 2022, 1:42 PM
Closed by commit rGb95c57444a8a: [HLSL] add sqrt library function (authored by bob80905, committed by beanz). · Explain Why
This revision was automatically updated to reflect the committed changes.
beanz added a commit: rGb95c57444a8a: [HLSL] add sqrt library function.
python3kgae added a subscriber: python3kgae.Sep 20 2022, 1:50 PM
python3kgae added inline comments.
clang/lib/Headers/hlsl/hlsl_intrinsics.h
18 ↗(On Diff #461687)

This should be removed.
We're using __builtin_elementwise_abs now.

Harbormaster completed remote builds in B187818: Diff 461674.Sep 20 2022, 1:53 PM

Revision Contents

PathSize
clang/
test/
CodeGenHLSL/
builtins/
4 lines

Diff 461636

clang/test/CodeGenHLSL/builtins/sqrt.hlsl

// RUN: %clang_cc1 -std=hlsl2021 -finclude-default-header -x hlsl -triple \ // RUN: %clang_cc1 -std=hlsl2021 -finclude-default-header -x hlsl -triple \
// RUN: dxil-pc-shadermodel6.3-library %s -fnative-half-type \ // RUN: dxil-pc-shadermodel6.2-library %s -fnative-half-type \
// RUN: -emit-llvm -disable-llvm-passes -o - | FileCheck %s // RUN: -emit-llvm -disable-llvm-passes -o - | FileCheck %s
// RUN: %clang_cc1 -std=hlsl2021 -finclude-default-header -x hlsl -triple \ // RUN: %clang_cc1 -std=hlsl2021 -finclude-default-header -x hlsl -triple \
// RUN: dxil-pc-shadermodel6.3-library %s -emit-llvm -disable-llvm-passes \ // RUN: dxil-pc-shadermodel6.2-library %s -emit-llvm -disable-llvm-passes \
// RUN: -o - | FileCheck %s --check-prefix=NO_HALF // RUN: -o - | FileCheck %s --check-prefix=NO_HALF
pow2clkUnsubmitted
Not Done
ReplyInline Actions

The -fnative-half-type suggests that you're readying this for when 16-bit types are available. That's fine, but in the spirit of starting as early as possible as we tend to do with these, you might want to target shadermodel6.2 instead since that's where they were introduced and sqrt is as old as HLSL 1.0 AFAIK.

pow2clk: The -fnative-half-type suggests that you're readying this for when 16-bit types are available.
double sqrt_d(double x) double sqrt_d(double x)
{ {
return sqrt(x); return sqrt(x);
} }
// CHECK: define noundef double @"?sqrt_d@@YANN@Z"( // CHECK: define noundef double @"?sqrt_d@@YANN@Z"(
// CHECK: call double @llvm.sqrt.f64(double %0) // CHECK: call double @llvm.sqrt.f64(double %0)
Show All 10 Lines
{ {
return sqrt(x); return sqrt(x);
} }
// CHECK: define noundef half @"?sqrt_h@@YA$f16@$f16@@Z"( // CHECK: define noundef half @"?sqrt_h@@YA$f16@$f16@@Z"(
// CHECK: call half @llvm.sqrt.f16(half %0) // CHECK: call half @llvm.sqrt.f16(half %0)
// NO_HALF: define noundef float @"?sqrt_h@@YA$halff@$halff@@Z"( // NO_HALF: define noundef float @"?sqrt_h@@YA$halff@$halff@@Z"(
// NO_HALF: call float @llvm.sqrt.f32(float %0) // NO_HALF: call float @llvm.sqrt.f32(float %0)
No newline at end of file No newline at end of file