This is an archive of the discontinued LLVM Phabricator instance.

[AArch64] Filter out invalid code model in frontend.
ClosedPublic

Authored by HsiangKai on Aug 24 2022, 1:34 AM.

Details

Summary

AArch64 only supports tiny, small, and large code model. Show error
messages when users specify other code model.

Fix https://github.com/llvm/llvm-project/issues/53402

Diff Detail

Event Timeline

HsiangKai created this revision.Aug 24 2022, 1:34 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 24 2022, 1:34 AM
HsiangKai requested review of this revision.Aug 24 2022, 1:34 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 24 2022, 1:34 AM
paquette accepted this revision.Aug 24 2022, 11:34 AM

Looks reasonable to me.

This revision is now accepted and ready to land.Aug 24 2022, 11:34 AM
paquette added inline comments.Aug 24 2022, 11:34 AM
clang/test/Driver/mcmodel.c
9

Do you need not in front of this? Can't remember.

HsiangKai updated this revision to Diff 455454.Aug 24 2022, 6:25 PM

Make the test lines consistent.

HsiangKai added inline comments.Aug 24 2022, 6:32 PM
clang/test/Driver/mcmodel.c
9

I use -### in the test lines. It will not execute commands. I changed them to be consistent with the previous 'invalid' test lines.

This revision was automatically updated to reflect the committed changes.