This is an archive of the discontinued LLVM Phabricator instance.

[lldb] Remove obsolete Android-specific definitions
ClosedPublic

Authored by pirama on Aug 23 2022, 3:59 PM.

Details

Summary

Bionic's <sys/procfs.h> defines the necessary symbols. Remove the
specialization for Android and the now-unnecessary include of
<sys/ptrace.h>. This also helps resolve issues when building the
x86/x86_64 lldb-server for Android.

Curiously, the default branch to include <sys/procfs.h> doesn't seem
necessary on Linux. I'll remove it and add it back if it breaks other
builders.

Diff Detail

Event Timeline

pirama created this revision.Aug 23 2022, 3:59 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 23 2022, 3:59 PM
pirama requested review of this revision.Aug 23 2022, 3:59 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 23 2022, 3:59 PM
enh accepted this revision.Aug 23 2022, 5:17 PM
This revision is now accepted and ready to land.Aug 23 2022, 5:17 PM
srhines accepted this revision.Aug 24 2022, 1:39 AM

Thanks for cleaning this up!

This revision was automatically updated to reflect the committed changes.