This allows reading arguments from file using the response file syntax.
We would like to use this in the LLVM build to pass test suites from
subbuilds.
Details
- Reviewers
yln jdenny thieta - Commits
- rGb52820edec6f: [lit] Support reading arguments from a file
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
So this is intended to help fix all the problems discussed at the reviews and issues below?
- https://github.com/llvm/llvm-project/issues/55082
- https://github.com/llvm/llvm-project/issues/54154
- https://reviews.llvm.org/D121276
- https://reviews.llvm.org/D121647
Please add documentation of the new feature to llvm/docs/CommandGuide/lit.rst.
Yes, that's correct, it's used in D132438.
Please add documentation of the new feature to llvm/docs/CommandGuide/lit.rst.
Done.
I am not Lit expert - but the python method seems to make sense reading the documentation and it doesn't seem to have any real downsides. I'll accept this - but if you want to wait for someone that understands lit better, I totally understand that.
llvm/docs/CommandGuide/lit.rst | ||
---|---|---|
47 | I'm not sure everyone reading this document will know what a response file is, and googling gave me inconsistent answers. Would you please add a brief explanation of the syntax? Is it one command-line option per line in the file? Can @ be used in a response file? |
llvm/docs/CommandGuide/lit.rst | ||
---|---|---|
47 | Updated in rG4f5cdbae887e9ab971a841dd123dec110ed12254. |
llvm/docs/CommandGuide/lit.rst | ||
---|---|---|
47 | Thanks. |
I'm not sure everyone reading this document will know what a response file is, and googling gave me inconsistent answers. Would you please add a brief explanation of the syntax? Is it one command-line option per line in the file? Can @ be used in a response file?