This is an archive of the discontinued LLVM Phabricator instance.

[lit] Support reading arguments from a file
ClosedPublic

Authored by phosek on Aug 22 2022, 11:32 PM.

Details

Summary

This allows reading arguments from file using the response file syntax.
We would like to use this in the LLVM build to pass test suites from
subbuilds.

Diff Detail

Event Timeline

phosek created this revision.Aug 22 2022, 11:32 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 22 2022, 11:32 PM
Herald added a subscriber: delcypher. · View Herald Transcript
phosek requested review of this revision.Aug 22 2022, 11:32 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 22 2022, 11:32 PM
phosek updated this revision to Diff 454707.Aug 22 2022, 11:33 PM

So this is intended to help fix all the problems discussed at the reviews and issues below?

Please add documentation of the new feature to llvm/docs/CommandGuide/lit.rst.

phosek updated this revision to Diff 455091.Aug 24 2022, 12:33 AM

Yes, that's correct, it's used in D132438.

Please add documentation of the new feature to llvm/docs/CommandGuide/lit.rst.

Done.

thieta accepted this revision.Aug 24 2022, 12:43 AM
thieta added a subscriber: thieta.

I am not Lit expert - but the python method seems to make sense reading the documentation and it doesn't seem to have any real downsides. I'll accept this - but if you want to wait for someone that understands lit better, I totally understand that.

This revision is now accepted and ready to land.Aug 24 2022, 12:43 AM
This revision was landed with ongoing or failed builds.Aug 24 2022, 1:02 AM
This revision was automatically updated to reflect the committed changes.
jdenny added inline comments.Aug 24 2022, 9:17 AM
llvm/docs/CommandGuide/lit.rst
47

I'm not sure everyone reading this document will know what a response file is, and googling gave me inconsistent answers. Would you please add a brief explanation of the syntax? Is it one command-line option per line in the file? Can @ be used in a response file?

phosek added inline comments.Aug 28 2022, 11:51 PM
llvm/docs/CommandGuide/lit.rst
47
jdenny added inline comments.Aug 29 2022, 10:48 AM
llvm/docs/CommandGuide/lit.rst
47

Thanks.