This is an archive of the discontinued LLVM Phabricator instance.

[mlir][memref] Remove extra brackets in doc
ClosedPublic

Authored by Peiming on Aug 18 2022, 11:03 AM.

Details

Summary

There is an (probably) unintended bracket in the documentation for memref.subview. See https://mlir.llvm.org/docs/Dialects/MemRef/#memrefsubview-mlirmemrefsubviewop below Example 5.

Diff Detail

Event Timeline

Peiming created this revision.Aug 18 2022, 11:03 AM
Peiming requested review of this revision.Aug 18 2022, 11:03 AM
Peiming edited the summary of this revision. (Show Details)Aug 18 2022, 11:05 AM
Peiming edited the summary of this revision. (Show Details)
aartbik accepted this revision.Aug 18 2022, 11:18 AM

I am baffled this worked, but perhaps tablegen is more forgiving than I thought?!

This revision is now accepted and ready to land.Aug 18 2022, 11:18 AM

Markdown is probably the forgiving one :) tblgen side [{ and }] demark the string literal but beyond that it doesn't care.

But yeah I was looking at some of the ops on mlir.dev and noticed some formatting issues, thanks for fixing this one!

This revision was landed with ongoing or failed builds.Aug 18 2022, 11:26 AM
This revision was automatically updated to reflect the committed changes.