[BOLT] Emit LSDA call sites for all fragments

[FPar]

Summary

For exception handling, LSDA call sites have to be emitted for each
fragment individually. With this patch, call sites and respective LSDA
symbols are generated and associated with each fragment of their
function, such that they can be used by the emitter.

[FPar]

Add test checking symbol table when split in multiple fragments

[Amir]

bolt/include/bolt/Core/BinaryFunction.h

1428

Why not using llvm::less_first here and below?

[FPar]

Use llvm::less_first instead of lambda

[FPar]

bolt/include/bolt/Core/BinaryFunction.h

1428

Because I was not aware of that function object. Thanks!

[FPar]

Rebase

[maksfb]

LGTM

bolt/include/bolt/Core/BinaryFunction.h

 #include "bolt/Core/BinaryContext.h"
 #include "bolt/Core/BinaryLoop.h"
 #include "bolt/Core/BinarySection.h"
 #include "bolt/Core/DebugData.h"
 #include "bolt/Core/FunctionLayout.h"
 #include "bolt/Core/JumpTable.h"
 #include "bolt/Core/MCPlus.h"
 #include "bolt/Utils/NameResolver.h"
+#include "llvm/ADT/STLExtras.h"
+#include "llvm/ADT/SmallString.h"
 #include "llvm/ADT/StringRef.h"
 #include "llvm/ADT/iterator.h"
+#include "llvm/ADT/iterator_range.h"
 #include "llvm/BinaryFormat/Dwarf.h"
 #include "llvm/MC/MCContext.h"
 #include "llvm/MC/MCDwarf.h"
 #include "llvm/MC/MCInst.h"
 #include "llvm/MC/MCSymbol.h"
 #include "llvm/Object/ObjectFile.h"
 #include "llvm/Support/raw_ostream.h"
 #include <algorithm>
+#include <iterator>
 #include <limits>
 #include <unordered_map>
 #include <unordered_set>
+#include <utility>
 #include <vector>
 
 using namespace llvm::object;
 
 namespace llvm {
 
 class DWARFUnit;
 
public:
   /// Struct for tracking exception handling ranges.
   struct CallSite {
     const MCSymbol *Start;
     const MCSymbol *End;
     const MCSymbol *LP;
     uint64_t Action;
   };
 
-  using CallSitesType = SmallVector<CallSite, 0>;
+  using CallSitesList = SmallVector<std::pair<FragmentNum, CallSite>, 0>;
+  using CallSitesRange = iterator_range<CallSitesList::const_iterator>;
 
   using IslandProxiesType =
       std::map<BinaryFunction *, std::map<const MCSymbol *, MCSymbol *>>;
 
   struct IslandInfo {
     /// Temporary holder of offsets that are data markers (used in AArch)
     /// It is possible to have data in code sections. To ease the identification
     /// of data in code sections, the ABI requires the symbol table to have
private:
   CFIInstrMapType FrameInstructions;
 
   /// A map of restore state CFI instructions to their equivalent CFI
   /// instructions that produce the same state, in order to eliminate
   /// remember-restore CFI instructions when rewriting CFI.
   DenseMap<int32_t, SmallVector<int32_t, 4>> FrameRestoreEquivalents;
 
   // For tracking exception handling ranges.
-  CallSitesType CallSites;
-  CallSitesType ColdCallSites;
+  CallSitesList CallSites;
 
   /// Binary blobs representing action, type, and type index tables for this
   /// function' LSDA (exception handling).
   ArrayRef<uint8_t> LSDAActionTable;
   ArrayRef<uint8_t> LSDATypeIndexTable;
 
   /// Vector of addresses of types referenced by LSDA.
   LSDATypeTableTy LSDATypeTable;
 
   /// Vector of addresses of entries in LSDATypeTable used for indirect
   /// addressing.
   LSDATypeTableTy LSDATypeAddressTable;
 
-  /// Marking for the beginning of language-specific data area for the function.
-  MCSymbol *LSDASymbol{nullptr};
-  MCSymbol *ColdLSDASymbol{nullptr};
+  /// Marking for the beginnings of language-specific data areas for each
+  /// fragment of the function.
+  SmallVector<MCSymbol *, 0> LSDASymbols;
 
   /// Map to discover which CFIs are attached to a given instruction offset.
   /// Maps an instruction offset into a FrameInstructions offset.
   /// This is only relevant to the buildCFG phase and is discarded afterwards.
   std::multimap<uint32_t, uint32_t> OffsetToCFI;
 
   /// List of CFI instructions associated with the CIE (common to more than one
   /// function and that apply before the entry basic block).
private:
   /// We still keep basic blocks for address translation/mapping purposes.
   void releaseCFG() {
     for (BinaryBasicBlock *BB : BasicBlocks)
       BB->releaseCFG();
     for (BinaryBasicBlock *BB : DeletedBasicBlocks)
       BB->releaseCFG();
 
     clearList(CallSites);
-    clearList(ColdCallSites);
     clearList(LSDATypeTable);
     clearList(LSDATypeAddressTable);
 
     clearList(LabelToBB);
 
     if (!isMultiEntry())
       clearList(Labels);
 
JumpTable *getJumpTable(const MCInst &Inst) {
     const uint64_t Address = BC.MIB->getJumpTable(Inst);
     return getJumpTableContainingAddress(Address);
   }
 
   const MCSymbol *getPersonalityFunction() const { return PersonalityFunction; }
 
   uint8_t getPersonalityEncoding() const { return PersonalityEncoding; }
 
-  const CallSitesType &getCallSites() const { return CallSites; }
+  CallSitesRange getCallSites(const FragmentNum F) const {
+    return make_range(std::equal_range(CallSites.begin(), CallSites.end(),
+                                       std::make_pair(F, CallSite()),
+                                       llvm::less_first()));
+  }
 
-  const CallSitesType &getColdCallSites() const { return ColdCallSites; }
+  void
+  addCallSites(const ArrayRef<std::pair<FragmentNum, CallSite>> NewCallSites) {
+    llvm::copy(NewCallSites, std::back_inserter(CallSites));
+    llvm::stable_sort(CallSites, llvm::less_first());
+  }
 
   ArrayRef<uint8_t> getLSDAActionTable() const { return LSDAActionTable; }
 
   const LSDATypeTableTy &getLSDATypeTable() const { return LSDATypeTable; }
 
   const LSDATypeTableTy &getLSDATypeAddressTable() const {
     return LSDATypeAddressTable;
   }

   void adjustExecutionCount(uint64_t Count);
 
   /// Set LSDA address for the function.
   BinaryFunction &setLSDAAddress(uint64_t Address) {
     LSDAAddress = Address;
     return *this;
   }
 
-  /// Set LSDA symbol for the function.
+  /// Set main LSDA symbol for the function.
   BinaryFunction &setLSDASymbol(MCSymbol *Symbol) {
-    LSDASymbol = Symbol;
+    if (LSDASymbols.empty())
+      LSDASymbols.resize(1);
+    LSDASymbols.front() = Symbol;
     return *this;
   }
 
   /// Return the profile information about the number of times
   /// the function was executed.
   ///
   /// Return COUNT_NO_PROFILE if there's no profile info.
   uint64_t getExecutionCount() const { return ExecutionCount; }
 
   /// Return the raw profile information about the number of branch
   /// executions corresponding to this function.
   uint64_t getRawBranchCount() const { return RawBranchCount; }
 
   /// Return the execution count for functions with known profile.
   /// Return 0 if the function has no profile.
   uint64_t getKnownExecutionCount() const {
     return ExecutionCount == COUNT_NO_PROFILE ? 0 : ExecutionCount;
   }
 
   /// Return original LSDA address for the function or NULL.
   uint64_t getLSDAAddress() const { return LSDAAddress; }
 
   /// Return symbol pointing to function's LSDA.
-  MCSymbol *getLSDASymbol() {
-    if (LSDASymbol)
-      return LSDASymbol;
-    if (CallSites.empty())
+  MCSymbol *getLSDASymbol(const FragmentNum F) {
+    if (F.get() < LSDASymbols.size() && LSDASymbols[F.get()] != nullptr)
+      return LSDASymbols[F.get()];
+    if (llvm::empty(getCallSites(F)))
       return nullptr;
 
-    LSDASymbol = BC.Ctx->getOrCreateSymbol(
-        Twine("GCC_except_table") + Twine::utohexstr(getFunctionNumber()));
+    if (F.get() >= LSDASymbols.size())
+      LSDASymbols.resize(F.get() + 1);
 
-    return LSDASymbol;
-  }
-
-  /// Return symbol pointing to function's LSDA for the cold part.
-  MCSymbol *getColdLSDASymbol(const FragmentNum Fragment) {
-    if (ColdLSDASymbol)
-      return ColdLSDASymbol;
-    if (ColdCallSites.empty())
-      return nullptr;
+    SmallString<256> SymbolName;
+    if (F == FragmentNum::main())
+      SymbolName = formatv("GCC_except_table{0:x-}", getFunctionNumber());
+    else
+      SymbolName = formatv("GCC_cold_except_table{0:x-}.{1}",
+                           getFunctionNumber(), F.get());
 
-    ColdLSDASymbol =
-        BC.Ctx->getOrCreateSymbol(formatv("GCC_cold_except_table{0:x-}.{1}",
-                                          getFunctionNumber(), Fragment.get()));
+    LSDASymbols[F.get()] = BC.Ctx->getOrCreateSymbol(SymbolName);
 
-    return ColdLSDASymbol;
+    return LSDASymbols[F.get()];
   }
 
   void setOutputDataAddress(uint64_t Address) { OutputDataOffset = Address; }
 
   uint64_t getOutputDataAddress() const { return OutputDataOffset; }
 
   void setOutputColdDataAddress(uint64_t Address) {
     OutputColdDataOffset = Address;

bolt/lib/Core/BinaryEmitter.cpp

private:
 
   /// Emit jump table data. Callee supplies sections for the data.
   void emitJumpTable(const JumpTable &JT, MCSection *HotSection,
                      MCSection *ColdSection);
 
   void emitCFIInstruction(const MCCFIInstruction &Inst) const;
 
   /// Emit exception handling ranges for the function.
-  void emitLSDA(BinaryFunction &BF, bool EmitColdPart);
+  void emitLSDA(BinaryFunction &BF, const FunctionFragment &FF);
 
   /// Emit line number information corresponding to \p NewLoc. \p PrevLoc
   /// provides a context for de-duplication of line number info.
   /// \p FirstInstr indicates if \p NewLoc represents the first instruction
   /// in a sequence, such as a function fragment.
   ///
   /// Return new current location which is either \p NewLoc or \p PrevLoc.
   SMLoc emitLineInfo(const BinaryFunction &BF, SMLoc NewLoc, SMLoc PrevLoc,
bool BinaryEmitter::emitFunction(BinaryFunction &Function,
   }
 
   // Emit CFI start
   if (Function.hasCFI()) {
     Streamer.emitCFIStartProc(/*IsSimple=*/false);
     if (Function.getPersonalityFunction() != nullptr)
       Streamer.emitCFIPersonality(Function.getPersonalityFunction(),
                                   Function.getPersonalityEncoding());
-    MCSymbol *LSDASymbol = FF.isSplitFragment()
-                               ? Function.getColdLSDASymbol(FF.getFragmentNum())
-                               : Function.getLSDASymbol();
+    MCSymbol *LSDASymbol = Function.getLSDASymbol(FF.getFragmentNum());
     if (LSDASymbol)
       Streamer.emitCFILsda(LSDASymbol, BC.LSDAEncoding);
     else
       Streamer.emitCFILsda(0, dwarf::DW_EH_PE_omit);
     // Emit CFI instructions relative to the CIE
     for (const MCCFIInstruction &CFIInstr : Function.cie()) {
       // Only write CIE CFI insns that LLVM will not already emit
       const std::vector<MCCFIInstruction> &FrameInstrs =
const MCExpr *SizeExpr = MCBinaryExpr::createSub(
         MCSymbolRefExpr::create(StartSymbol, Context), Context);
     Streamer.emitELFSize(StartSymbol, SizeExpr);
   }
 
   if (opts::UpdateDebugSections && Function.getDWARFUnit())
     emitLineInfoEnd(Function, EndSymbol);
 
   // Exception handling info for the function.
-  emitLSDA(Function, FF.isSplitFragment());
+  emitLSDA(Function, FF);
 
   if (FF.isMainFragment() && opts::JumpTables > JTS_NONE)
     emitJumpTables(Function);
 
   return true;
 }
 
 void BinaryEmitter::emitFunctionBody(BinaryFunction &BF, FunctionFragment &FF,
case MCCFIInstruction::OpRestore:
     break;
   case MCCFIInstruction::OpUndefined:
     Streamer.emitCFIUndefined(Inst.getRegister());
     break;
   }
 }
 
 // The code is based on EHStreamer::emitExceptionTable().
-void BinaryEmitter::emitLSDA(BinaryFunction &BF, bool EmitColdPart) {
-  const BinaryFunction::CallSitesType *Sites =
-      EmitColdPart ? &BF.getColdCallSites() : &BF.getCallSites();
-  if (Sites->empty())
+void BinaryEmitter::emitLSDA(BinaryFunction &BF, const FunctionFragment &FF) {
+  const BinaryFunction::CallSitesRange Sites =
+      BF.getCallSites(FF.getFragmentNum());
+  if (llvm::empty(Sites))
     return;
 
   // Calculate callsite table size. Size of each callsite entry is:
   //
   //  sizeof(start) + sizeof(length) + sizeof(LP) + sizeof(uleb128(action))
   //
   // or
   //
   //  sizeof(dwarf::DW_EH_PE_data4) * 3 + sizeof(uleb128(action))
-  uint64_t CallSiteTableLength = Sites->size() * 4 * 3;
-  for (const BinaryFunction::CallSite &CallSite : *Sites)
-    CallSiteTableLength += getULEB128Size(CallSite.Action);
+  uint64_t CallSiteTableLength = llvm::size(Sites) * 4 * 3;
+  for (const auto &FragmentCallSite : Sites)
+    CallSiteTableLength += getULEB128Size(FragmentCallSite.second.Action);
 
   Streamer.switchSection(BC.MOFI->getLSDASection());
 
   const unsigned TTypeEncoding = BC.TTypeEncoding;
   const unsigned TTypeEncodingSize = BC.getDWARFEncodingSize(TTypeEncoding);
   const uint16_t TTypeAlignment = 4;
 
   // Type tables have to be aligned at 4 bytes.
   Streamer.emitValueToAlignment(TTypeAlignment);
 
   // Emit the LSDA label.
-  MCSymbol *LSDASymbol = EmitColdPart
-                             ? BF.getColdLSDASymbol(FragmentNum::cold())
-                             : BF.getLSDASymbol();
+  MCSymbol *LSDASymbol = BF.getLSDASymbol(FF.getFragmentNum());
   assert(LSDASymbol && "no LSDA symbol set");
   Streamer.emitLabel(LSDASymbol);
 
   // Corresponding FDE start.
-  const MCSymbol *StartSymbol =
-      BF.getSymbol(EmitColdPart ? FragmentNum::cold() : FragmentNum::main());
+  const MCSymbol *StartSymbol = BF.getSymbol(FF.getFragmentNum());
 
   // Emit the LSDA header.
 
   // If LPStart is omitted, then the start of the FDE is used as a base for
   // landing pad displacements. Then if a cold fragment starts with
   // a landing pad, this means that the first landing pad offset will be 0.
   // As a result, the exception handling runtime will ignore this landing pad
   // because zero offset denotes the absence of a landing pad.
Streamer.emitULEB128IntValue(TTypeBaseOffset,
                                /*PadTo=*/TTypeBaseOffsetSize + SizeAlign);
 
   // Emit the landing pad call site table. We use signed data4 since we can emit
   // a landing pad in a different part of the split function that could appear
   // earlier in the address space than LPStart.
   Streamer.emitIntValue(dwarf::DW_EH_PE_sdata4, 1);
   Streamer.emitULEB128IntValue(CallSiteTableLength);
 
-  for (const BinaryFunction::CallSite &CallSite : *Sites) {
+  for (const auto &FragmentCallSite : Sites) {
+    const BinaryFunction::CallSite &CallSite = FragmentCallSite.second;
     const MCSymbol *BeginLabel = CallSite.Start;
     const MCSymbol *EndLabel = CallSite.End;
 
     assert(BeginLabel && "start EH label expected");
     assert(EndLabel && "end EH label expected");
 
     // Start of the range is emitted relative to the start of current
     // function split part.

bolt/lib/Core/BinaryFunction.cpp

for (const BinaryBasicBlock *BB : FF) {
 
       OS << '\n';
     }
   }
 
   // Dump new exception ranges for the function.
   if (!CallSites.empty()) {
     OS << "EH table:\n";
-    for (const CallSite &CSI : CallSites) {
+    for (const FunctionFragment &FF : getLayout().fragments()) {
+      for (const auto &FCSI : getCallSites(FF.getFragmentNum())) {
+        const CallSite &CSI = FCSI.second;
         OS << "  [" << *CSI.Start << ", " << *CSI.End << ") landing pad : ";
         if (CSI.LP)
           OS << *CSI.LP;
         else
           OS << "0";
         OS << ", action : " << CSI.Action << '\n';
       }
+    }
     OS << '\n';
   }
 
   // Print all jump tables.
   for (const std::pair<const uint64_t, JumpTable *> &JTI : JumpTables)
     JTI.second->print(OS);
 
   OS << "DWARF CFI Instructions:\n";

bolt/lib/Core/Exceptions.cpp

void BinaryFunction::updateEHRanges() {
   assert(CurrentState == State::CFG_Finalized && "unexpected state");
 
   // Build call sites table.
   struct EHInfo {
     const MCSymbol *LP; // landing pad
     uint64_t Action;
   };
 
-  for (FunctionFragment &FF : getLayout().fragments()) {
-    // Sites to update - either regular or cold.
-    CallSitesType &Sites = FF.isMainFragment() ? CallSites : ColdCallSites;
+  // Sites to update.
+  CallSitesList Sites;
 
+  for (FunctionFragment &FF : getLayout().fragments()) {
     // If previous call can throw, this is its exception handler.
     EHInfo PreviousEH = {nullptr, 0};
 
     // Marker for the beginning of exceptions range.
     const MCSymbol *StartRange = nullptr;
 
     for (BinaryBasicBlock *const BB : FF) {
       for (auto II = BB->begin(); II != BB->end(); ++II) {
         if (!BC.MIB->isCall(*II))
           continue;
 
         // Instruction can throw an exception that should be handled.
         const bool Throws = BC.MIB->isInvoke(*II);
 
         // Ignore the call if it's a continuation of a no-throw gap.
         if (!Throws && !StartRange)
           continue;
 
-        assert(getLayout().isHotColdSplit() &&
-               "Exceptions only supported for hot/cold splitting");
-
         // Extract exception handling information from the instruction.
         const MCSymbol *LP = nullptr;
         uint64_t Action = 0;
         if (const Optional<MCPlus::MCLandingPad> EHInfo =
                 BC.MIB->getEHInfo(*II))
           std::tie(LP, Action) = *EHInfo;
 
         // No action if the exception handler has not changed.
for (BinaryBasicBlock *const BB : FF) {
           EndRange = EHSymbol;
         } else {
           // II:
           StartRange = EHSymbol;
           EndRange = nullptr;
         }
 
         // Close the previous range.
-        if (EndRange) {
+        if (EndRange)
           Sites.emplace_back(
+              FF.getFragmentNum(),
               CallSite{StartRange, EndRange, PreviousEH.LP, PreviousEH.Action});
-        }
 
         if (Throws) {
           // I, II:
           StartRange = EHSymbol;
           PreviousEH = EHInfo{LP, Action};
         } else {
           StartRange = nullptr;
         }
       }
     }
 
     // Check if we need to close the range.
     if (StartRange) {
-      assert((FF.isMainFragment() || &Sites == &ColdCallSites) &&
-             "sites mismatch");
       const MCSymbol *EndRange = getFunctionEndLabel(FF.getFragmentNum());
       Sites.emplace_back(
+          FF.getFragmentNum(),
           CallSite{StartRange, EndRange, PreviousEH.LP, PreviousEH.Action});
     }
   }
+
+  addCallSites(Sites);
 }
 
 const uint8_t DWARF_CFI_PRIMARY_OPCODE_MASK = 0xc0;
 
 CFIReaderWriter::CFIReaderWriter(const DWARFDebugFrame &EHFrame) {
   // Prepare FDEs for fast lookup
   for (const dwarf::FrameEntry &Entry : EHFrame.entries()) {
     const auto *CurFDE = dyn_cast<dwarf::FDE>(&Entry);

bolt/lib/Passes/SplitFunctions.cpp

for (BinaryBasicBlock *const BB : make_range(Start, End)) {
       ++BBPos;
     }
   }
 };
 
 struct SplitAll final : public SplitStrategy {
   bool canSplit(const BinaryFunction &BF) override { return true; }
 
-  bool keepEmpty() override { return false; }
+  bool keepEmpty() override {
+    // Keeping empty fragments allows us to test, that empty fragments do not
+    // generate symbols.
+    return true;
+  }
 
   void fragment(const BlockIt Start, const BlockIt End) override {
     unsigned Fragment = 0;
     for (BinaryBasicBlock *const BB : llvm::make_range(Start, End))
       BB->setFragmentNum(FragmentNum(Fragment++));
   }
 };
 } // namespace

bolt/test/X86/fragmented-symbols.s

+# Checks that symbols are allocated in correct sections, and that empty
+# fragments are not allocated at all.
+
+# REQUIRES: x86_64-linux
+
+# RUN: llvm-mc -filetype=obj -triple x86_64-unknown-unknown %s -o %t.o
+# RUN: %clangxx %cxxflags %t.o -o %t.exe -Wl,-q -no-pie
+# RUN: llvm-bolt %t.exe -o %t.bolt --split-functions --split-strategy=all \
+# RUN:         --print-split --print-only=_Z3foov 2>&1 | \
+# RUN:     FileCheck %s --check-prefix=CHECK-SPLIT
+# RUN: llvm-nm %t.bolt | FileCheck %s --check-prefix=CHECK-COLD0
+# RUN: llvm-objdump --syms %t.bolt | \
+# RUN:     FileCheck %s --check-prefix=CHECK-SYMS
+
+# CHECK-SPLIT: .LLP0 (4 instructions, align : 1)
+# CHECK-SPLIT: -------   HOT-COLD SPLIT POINT   -------
+# CHECK-SPLIT-EMPTY:
+# CHECK-SPLIT-NEXT: -------   HOT-COLD SPLIT POINT   -------
+# CHECK-SPLIT-EMPTY:
+# CHECK-SPLIT-NEXT: .LFT0 (2 instructions, align : 1)
+
+# CHECK-COLD0-NOT: _Z3foov.cold.0
+
+# CHECK-SYMS: .text.cold.1
+# CHECK-SYMS-SAME: _Z3foov.cold.1
+# CHECK-SYMS: .text.cold.2
+# CHECK-SYMS-SAME: _Z3foov.cold.2
+# CHECK-SYMS: .text.cold.3
+# CHECK-SYMS-SAME: _Z3foov.cold.3
+
+
+        .text
+        .globl  _Z3barv
+        .type   _Z3barv, @function
+_Z3barv:                            # void bar();
+        .cfi_startproc
+        ret
+        .cfi_endproc
+        .size   _Z3barv, .-_Z3barv
+
+
+        .globl  _Z3bazv
+        .type   _Z3bazv, @function
+_Z3bazv:                            # void baz() noexcept;
+        .cfi_startproc
+        ret
+        .cfi_endproc
+        .size   _Z3bazv, .-_Z3bazv
+
+
+        .globl  _Z3foov
+        .type   _Z3foov, @function
+_Z3foov:                            # void foo() noexcept;
+.LFB1265:                           # _Z3foov
+        .cfi_startproc
+        .cfi_personality 0x3,__gxx_personality_v0
+        .cfi_lsda 0x3,.LLSDA1265
+        subq    $8, %rsp
+        .cfi_def_cfa_offset 16
+.LEHB0:
+        call    _Z3barv             # LP: .L5
+.LEHE0:
+        jmp     .L4
+.L5:                                # (_Z3foov.cold.0), landing pad, hot
+        movq    %rax, %rdi
+        cmpq    $1, %rdx
+        je      .L3
+        call    _ZSt9terminatev     # _Z3foov.cold.1
+.L3:                                # _Z3foov.cold.2
+        call    __cxa_begin_catch
+        call    _Z3bazv
+        call    __cxa_end_catch
+.L4:                                # _Z3foov.cold.3
+        call    _Z3bazv
+        addq    $8, %rsp
+        .cfi_def_cfa_offset 8
+        ret
+        .cfi_endproc
+        .globl  __gxx_personality_v0
+        .section        .gcc_except_table,"a",@progbits
+        .align 4
+.LLSDA1265:
+        .byte   0xff
+        .byte   0x3
+        .uleb128 .LLSDATT1265-.LLSDATTD1265
+.LLSDATTD1265:
+        .byte   0x1
+        .uleb128 .LLSDACSE1265-.LLSDACSB1265
+.LLSDACSB1265:
+        .uleb128 .LEHB0-.LFB1265
+        .uleb128 .LEHE0-.LEHB0
+        .uleb128 .L5-.LFB1265
+        .uleb128 0x3
+.LLSDACSE1265:
+        .byte   0
+        .byte   0
+        .byte   0x1
+        .byte   0x7d
+        .align 4
+        .long   _ZTISt13runtime_error
+.LLSDATT1265:
+        .text
+        .size   _Z3foov, .-_Z3foov
+
+
+        .globl  main
+        .type   main, @function
+main:
+        .cfi_startproc
+        subq    $8, %rsp
+        .cfi_def_cfa_offset 16
+        call    _Z3foov
+        movl    $0, %eax
+        addq    $8, %rsp
+        .cfi_def_cfa_offset 8
+        ret
+        .cfi_endproc
+        .size   main, .-main

bolt/test/runtime/X86/exceptions-pic.test

 # Verify that C++ exceptions work after binary re-writing
 
 REQUIRES: x86_64-linux
 
 RUN: %clangxx -fpic -Wl,-q %S/Inputs/exception4.cpp -o %t.pic
 RUN: llvm-bolt %t.pic -o %t && %t 2>&1 | FileCheck %s
 RUN: llvm-bolt --relocs --use-old-text %t.pic -o %t && %t 2>&1 | FileCheck %s
+RUN: llvm-bolt %t.pic -o %t --split-functions --split-strategy=all --split-eh && \
+RUN:     %t 2>&1 | FileCheck %s
 
 CHECK: catch 2
 CHECK-NEXT: catch 1
 CHECK-NEXT: caught ExcC
-
-

bolt/test/runtime/X86/rethrow.cpp

+#include <iostream>
+#include <stdexcept>
+
+void erringFunc() { throw std::runtime_error("Hello"); }
+
+void libCallA() { erringFunc(); }
+
+void libCallB() { throw std::runtime_error("World"); }
+
+void handleEventA() {
+  try {
+    libCallA();
+  } catch (std::runtime_error &E) {
+    std::cout << "handleEventA: unhandled error " << E.what() << "\n";
+    throw;
+  }
+}
+
+void handleEventB() {
+  try {
+    libCallB();
+  } catch (std::runtime_error &E) {
+    std::cout << "handleEventB: handle error " << E.what() << "\n";
+  }
+}
+
+class EventGen {
+  unsigned RemainingEvents = 5;
+
+public:
+  int generateEvent() {
+    if (RemainingEvents > 0) {
+      --RemainingEvents;
+      return (RemainingEvents % 3) + 1;
+    }
+    return 0;
+  }
+};
+
+class TerminateException : public std::runtime_error {
+public:
+  TerminateException() : std::runtime_error("Time to stop!") {}
+};
+
+void runEventLoop(EventGen &EG) {
+  while (true) {
+    try {
+      int Ev = EG.generateEvent();
+      switch (Ev) {
+      case 0:
+        throw TerminateException();
+      case 1:
+        handleEventA();
+        break;
+      case 2:
+        handleEventB();
+        break;
+      }
+    } catch (TerminateException &E) {
+      std::cout << "Terminated?\n";
+      throw;
+    } catch (std::runtime_error &E) {
+      std::cout << "Unhandled error: " << E.what() << "\n";
+    }
+  }
+}
+
+struct CleanUp {
+  ~CleanUp() { std::cout << "Cleanup\n"; }
+};
+
+int main() {
+  EventGen EG;
+  try {
+    CleanUp CU;
+    runEventLoop(EG);
+  } catch (TerminateException &E) {
+    std::cout << "Terminated!\n";
+  }
+  return 0;
+}
+
+/*
+REQUIRES: system-linux
+
+RUN: %clang++ %cflags %s -o %t.exe -Wl,-q
+RUN: llvm-bolt %t.exe --split-functions --split-strategy=randomN \
+RUN:         --split-all-cold --split-eh --bolt-seed=7 -o %t.bolt
+RUN: %t.bolt | FileCheck %s
+
+CHECK: handleEventB: handle error World
+CHECK-NEXT: handleEventA: unhandled error Hello
+CHECK-NEXT: Unhandled error: Hello
+CHECK-NEXT: handleEventB: handle error World
+CHECK-NEXT: handleEventA: unhandled error Hello
+CHECK-NEXT: Unhandled error: Hello
+CHECK-NEXT: Terminated?
+CHECK-NEXT: Cleanup
+CHECK-NEXT: Terminated!
+*/