Details
Details
- Reviewers
ldionne Mordante var-const huixie90 - Group Reviewers
Restricted Project - Commits
- rG786366b18fad: [libc++][NFC] Remove some of the code duplication in the string tests
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
LGTM
libcxx/test/std/strings/basic.string/string.modifiers/string_append/string.pass.cpp | ||
---|---|---|
59 | In one place, I saw you changed from > 3 to >= 11. To be consistent, either change this one too or revert the other change. |
Comment Actions
LGTM w/ comments.
libcxx/test/std/strings/basic.string/string.modifiers/string_append/string.pass.cpp | ||
---|---|---|
59 | This is so weird, we should use TEST_STD_VER >= 11 everywhere. I didn't know we had TEST_STD_VER > 3 anywhere in the code base. |
In one place, I saw you changed from > 3 to >= 11. To be consistent, either change this one too or revert the other change.
I suppose this is checking the version is > Cxx03. I thought we need to use a different macro to check if the version is CXX03 in the non-test code and didn't know that this is working.