This is an archive of the discontinued LLVM Phabricator instance.

[mlir] Add AllOfType and ConfinedType constraints
ClosedPublic

Authored by Mogball on Aug 12 2022, 9:35 AM.

Details

Summary

AllOfType is a type constraint that satisfies all given type
constraints and ConfinedType is a type that satisfies additional
predicates. These shorthands simplify type constraint definition mostly
by removing the need to deal with myType.predicate manipulation.

Diff Detail

Event Timeline

Mogball created this revision.Aug 12 2022, 9:35 AM
Mogball requested review of this revision.Aug 12 2022, 9:35 AM
jpienaar accepted this revision.Aug 12 2022, 10:55 AM

Nice, looks cleaner thanks

This revision is now accepted and ready to land.Aug 12 2022, 10:55 AM
This revision was landed with ongoing or failed builds.Aug 12 2022, 1:25 PM
This revision was automatically updated to reflect the committed changes.

LG!

Can you rename AllAttrConstraintsOf to be aligned? AllOfAttr is a much nicer name. It'd also be nice to rename Confined to ConfinedAttr at some point as well.