This is an archive of the discontinued LLVM Phabricator instance.

Differential D131596

[mlir] Fix calling the native mlir-pdll-tblgen
ClosedPublic

Authored by marbre on Aug 10 2022, 10:31 AM.

Details

Reviewers
mstorsjo
jpienaar
Commits
rG91b6f76a582a: [mlir] Fix calling the native mlir-pdll-tblgen
Summary

This sets the MLIR_PDLL_TABLEGEN_EXE and MLIR_PDLL_TABLEGEN_TARGET
as cache variables which is necessary for cross-compiling projects that
rely on MLIR and the mlir-pdll-tblgen tool.

The patch is similar to https://reviews.llvm.org/D130350.

Diff Detail

Event Timeline

marbre created this revision.Aug 10 2022, 10:31 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 10 2022, 10:31 AM
Herald added subscribers: bzcheeseman, sdasgup3, wenzhicui and 19 others. · View Herald Transcript
marbre requested review of this revision.Aug 10 2022, 10:31 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 10 2022, 10:31 AM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
jpienaar accepted this revision.Aug 10 2022, 10:39 AM
This revision is now accepted and ready to land.Aug 10 2022, 10:39 AM
Harbormaster completed remote builds in B180456: Diff 451545.Aug 10 2022, 1:04 PM
Closed by commit rG91b6f76a582a: [mlir] Fix calling the native mlir-pdll-tblgen (authored by marbre). · Explain WhyAug 11 2022, 2:34 AM
This revision was automatically updated to reflect the committed changes.
marbre added a commit: rG91b6f76a582a: [mlir] Fix calling the native mlir-pdll-tblgen.

Revision Contents

PathSize
mlir/
2 lines

Diff 451782

mlir/CMakeLists.txt

Show First 20 Lines • Show All 158 Lines • ▼ Show 20 Lines
# MLIR_TABLEGEN_EXE in PARENT_SCOPE which gets lost if that folder is included # MLIR_TABLEGEN_EXE in PARENT_SCOPE which gets lost if that folder is included
# from another directory like tools # from another directory like tools
add_subdirectory(tools/mlir-tblgen) add_subdirectory(tools/mlir-tblgen)
add_subdirectory(tools/mlir-linalg-ods-gen) add_subdirectory(tools/mlir-linalg-ods-gen)
add_subdirectory(tools/mlir-pdll) add_subdirectory(tools/mlir-pdll)
set(MLIR_TABLEGEN_EXE "${MLIR_TABLEGEN_EXE}" CACHE INTERNAL "") set(MLIR_TABLEGEN_EXE "${MLIR_TABLEGEN_EXE}" CACHE INTERNAL "")
set(MLIR_TABLEGEN_TARGET "${MLIR_TABLEGEN_TARGET}" CACHE INTERNAL "") set(MLIR_TABLEGEN_TARGET "${MLIR_TABLEGEN_TARGET}" CACHE INTERNAL "")
set(MLIR_PDLL_TABLEGEN_EXE "${MLIR_PDLL_TABLEGEN_EXE}" CACHE INTERNAL "")
set(MLIR_PDLL_TABLEGEN_TARGET "${MLIR_PDLL_TABLEGEN_TARGET}" CACHE INTERNAL "")
add_subdirectory(include/mlir) add_subdirectory(include/mlir)
add_subdirectory(lib) add_subdirectory(lib)
# C API needs all dialects for registration, but should be built before tests. # C API needs all dialects for registration, but should be built before tests.
add_subdirectory(lib/CAPI) add_subdirectory(lib/CAPI)
if (MLIR_INCLUDE_TESTS) if (MLIR_INCLUDE_TESTS)
add_definitions(-DMLIR_INCLUDE_TESTS) add_definitions(-DMLIR_INCLUDE_TESTS)
▲ Show 20 Lines • Show All 86 Lines • Show Last 20 Lines