This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU][MC][GFX11][NFC] Consolidate VOP tests
ClosedPublic

Authored by dp on Aug 10 2022, 5:35 AM.

Details

Summary

Summary of changes:

  • Consolidate VOP tests by encoding. Currently, some files include tests for many encodings.
  • Separate VOP1/VOP2/VOPC tests. Some of these need additional corrections because they use 16-bit VGPRs they cannot really address.
  • Separate tests for v_cmp_ and v_cmpx_ opcodes.
  • Remove identical tests (found more than 1000).

Diff Detail

Event Timeline

dp created this revision.Aug 10 2022, 5:35 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 10 2022, 5:35 AM
dp requested review of this revision.Aug 10 2022, 5:35 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 10 2022, 5:35 AM
Joe_Nash accepted this revision.Aug 10 2022, 8:27 AM

In principle I like all of this. I have spot checked a few instructions. The only thing I am concerned about is if some scripting error accidentally deleted a few tests. I don't see a way to verify that other than to repeat whatever script you had. If you are confident there are no errors of that type, LGTM.

This revision is now accepted and ready to land.Aug 10 2022, 8:27 AM
dp added a comment.Aug 10 2022, 9:45 AM

Thanks. I was also concerned with scripting errors, so I sorted and dumped all affected tests into one file before and after each change. Diffing the dumps helped to ensure no tests were lost during transformations.

This revision was landed with ongoing or failed builds.Aug 11 2022, 5:02 AM
This revision was automatically updated to reflect the committed changes.
llvm/test/MC/AMDGPU/gfx11_asm_vopc_dpp8.s