This is an archive of the discontinued LLVM Phabricator instance.

[LegalizeTypes][NFC] Use dyn_cast instead of isa and cast.
ClosedPublic

Authored by Jimerlife on Aug 9 2022, 11:59 PM.

Details

Diff Detail

Event Timeline

Jimerlife created this revision.Aug 9 2022, 11:59 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 9 2022, 11:59 PM
Jimerlife requested review of this revision.Aug 9 2022, 11:59 PM
craig.topper added inline comments.Aug 10 2022, 9:51 AM
llvm/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp
3036–3037

There shouldn't be a space before Index

Jimerlife updated this revision to Diff 451699.Aug 10 2022, 6:43 PM

address comment

Jimerlife marked an inline comment as done.Aug 10 2022, 6:43 PM
Jimerlife updated this revision to Diff 452073.Aug 11 2022, 9:13 PM

update and add const keyword

This revision is now accepted and ready to land.Aug 11 2022, 9:15 PM