This is an archive of the discontinued LLVM Phabricator instance.

[LoongArch] Add codegen support for not
ClosedPublic

Authored by gonglingqin on Aug 8 2022, 1:40 AM.

Diff Detail

Event Timeline

gonglingqin created this revision.Aug 8 2022, 1:40 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 8 2022, 1:40 AM
gonglingqin requested review of this revision.Aug 8 2022, 1:40 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 8 2022, 1:40 AM
xen0n added inline comments.Aug 8 2022, 2:03 AM
llvm/lib/Target/LoongArch/LoongArchInstrInfo.td
664

This is the same codegen as gcc, while I previously used NOR rj, zero (putting zero in rk position) in my QEMU TCG port.

I'm not sure which form is better or more consistent, because apparently they behave the same but usually we put zero in rk position (like with move i.e. move rd, rj == or rd, rj, zero).

665

nit: single space.

same below

gonglingqin added inline comments.Aug 8 2022, 2:33 AM
llvm/lib/Target/LoongArch/LoongArchInstrInfo.td
664

Thank you for your reminder , I will change that.

665

Thanks, I will fix it.

Address @xen0n's comments.

xen0n accepted this revision.Aug 8 2022, 2:51 AM
This revision is now accepted and ready to land.Aug 8 2022, 2:51 AM
MaskRay accepted this revision.Aug 8 2022, 8:44 PM
This revision was automatically updated to reflect the committed changes.