This is an archive of the discontinued LLVM Phabricator instance.

[docs][AArch64] Label Features with Arm ARM Names
ClosedPublic

Authored by lenary on Aug 5 2022, 6:43 AM.

Details

Summary

This patch adds the names of the Arm Architecture Reference Manual (ARM)
features to the corresponding Subtarget Features in the AArch64 backend
and target parser.

The aim of this is to make it clearer what architectural features a
subtarget feature might enable (so, which features a CPU must provide to
support that subtarget feature), and so make it easier to add new CPUs
in the future.

Diff Detail

Event Timeline

lenary created this revision.Aug 5 2022, 6:43 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 5 2022, 6:43 AM
lenary requested review of this revision.Aug 5 2022, 6:43 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 5 2022, 6:43 AM
dmgreen accepted this revision.Aug 8 2022, 12:24 AM

LGTM. Looks like a useful addition. D127812 has need of some of these same FEAT_ names.

llvm/include/llvm/Support/AArch64TargetParser.h
34–35

The reference I have mentions FEAT_FP and FEAT_AdvSIMD.

llvm/lib/Target/AArch64/AArch64.td
322

Should this be FEAT_MPAM?

This revision is now accepted and ready to land.Aug 8 2022, 12:24 AM
lenary marked 2 inline comments as done.Aug 8 2022, 3:42 AM
lenary added inline comments.
llvm/include/llvm/Support/AArch64TargetParser.h
34–35

Updates incoming.

llvm/lib/Target/AArch64/AArch64.td
322

Updates incoming.

lenary updated this revision to Diff 450752.Aug 8 2022, 3:44 AM
lenary marked 2 inline comments as done.
This revision was landed with ongoing or failed builds.Aug 9 2022, 10:46 AM
This revision was automatically updated to reflect the committed changes.