Page MenuHomePhabricator

Desist from passing function location to __msan_set_alloca_origin4.
ClosedPublic

Authored by kda on Thu, Aug 4, 2:41 PM.

Details

Summary

This is done by calling __msan_set_alloca_origin and providing the location of the variable by using the call stack.
This is prepatory work for dropping variable names when track-origins is enabled.

Diff Detail

Event Timeline

kda created this revision.Thu, Aug 4, 2:41 PM
Herald added a project: Restricted Project. · View Herald TranscriptThu, Aug 4, 2:41 PM
kda requested review of this revision.Thu, Aug 4, 2:41 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptThu, Aug 4, 2:41 PM
Herald added subscribers: llvm-commits, Restricted Project. · View Herald Transcript
kda updated this revision to Diff 450135.Thu, Aug 4, 2:42 PM

pick up the other changes.

kda updated this revision to Diff 450136.Thu, Aug 4, 2:44 PM

correct formatting of long line.

vitalybuka accepted this revision.Fri, Aug 5, 1:45 PM
vitalybuka added inline comments.
compiler-rt/lib/msan/msan.cpp
590

static_cast?

This revision is now accepted and ready to land.Fri, Aug 5, 1:45 PM
vitalybuka added inline comments.Fri, Aug 5, 1:48 PM
compiler-rt/lib/msan/msan.cpp
590

I mean reinterpret_cast

kda updated this revision to Diff 450451.Fri, Aug 5, 4:51 PM
kda marked an inline comment as done.

add reinterpret_cast

kda requested review of this revision.Fri, Aug 5, 4:52 PM
kda updated this revision to Diff 451513.Wed, Aug 10, 9:02 AM

rebase to main

This revision was not accepted when it landed; it landed in state Needs Review.Wed, Aug 10, 9:03 AM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.

All three bots back to green.
Thank you for your help.