This is an archive of the discontinued LLVM Phabricator instance.

[MSAN] add flag to suppress storage of stack variable names with -sanitize-memory-track-origins
ClosedPublic

Authored by kda on Aug 11 2022, 3:02 PM.

Details

Summary

Allows for even more savings in the binary image while simultaneously removing the name of the offending stack variable.

Depends on D131631

Diff Detail

Event Timeline

kda created this revision.Aug 11 2022, 3:02 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 11 2022, 3:02 PM
kda requested review of this revision.Aug 11 2022, 3:02 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptAug 11 2022, 3:02 PM
Herald added subscribers: llvm-commits, Restricted Project. · View Herald Transcript
vitalybuka added inline comments.Aug 11 2022, 6:15 PM
compiler-rt/lib/msan/msan.cpp
627

remove StackTrace::GetPreviousInstructionPc

compiler-rt/lib/msan/msan_interface_internal.h
116

pc is not needed

kda updated this revision to Diff 452065.Aug 11 2022, 8:23 PM
kda marked 2 inline comments as done.

drop pc from new function and fix/improve IR test

vitalybuka accepted this revision.Aug 11 2022, 9:16 PM
This revision is now accepted and ready to land.Aug 11 2022, 9:16 PM
kda updated this revision to Diff 452256.Aug 12 2022, 11:43 AM

update after rebase

This revision was landed with ongoing or failed builds.Aug 12 2022, 11:59 AM
This revision was automatically updated to reflect the committed changes.
vitalybuka added inline comments.Aug 12 2022, 4:06 PM
compiler-rt/lib/msan/msan_report.cpp
40–48

nits

  1. we usually use implicit conversion to bool for pointers checking
  2. positive branch first
kda added inline comments.Aug 15 2022, 9:34 AM
compiler-rt/lib/msan/msan_report.cpp
40–48

followed up with D131903