This is an archive of the discontinued LLVM Phabricator instance.

Differential D131055

[ORC] Fix a warning about an unused variable on Windows. NFC.
ClosedPublic

Authored by mstorsjo on Aug 3 2022, 1:09 AM.

Details

Reviewers
lhames
sgraenitz
argentite
Commits
rG46196db4d305: [ORC] Fix a warning about an unused variable on Windows. NFC.

Diff Detail

Event Timeline

mstorsjo created this revision.Aug 3 2022, 1:09 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 3 2022, 1:09 AM
Herald added subscribers: StephenFan, hiraditya. · View Herald Transcript
mstorsjo requested review of this revision.Aug 3 2022, 1:09 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 3 2022, 1:09 AM
Harbormaster completed remote builds in B178968: Diff 449573.Aug 3 2022, 1:57 AM
argentite accepted this revision.Aug 3 2022, 10:16 AM

Thanks for the fix.

This revision is now accepted and ready to land.Aug 3 2022, 10:16 AM
Closed by commit rG46196db4d305: [ORC] Fix a warning about an unused variable on Windows. NFC. (authored by mstorsjo). · Explain WhyAug 4 2022, 1:15 AM
This revision was automatically updated to reflect the committed changes.
mstorsjo added a commit: rG46196db4d305: [ORC] Fix a warning about an unused variable on Windows. NFC..

Revision Contents

PathSize
llvm/
lib/
ExecutionEngine/
Orc/
TargetProcess/
1 line

Diff 449573

llvm/lib/ExecutionEngine/Orc/TargetProcess/ExecutorSharedMemoryMapperService.cpp

Show First 20 Lines • Show All 235 Lines • ▼ Show 20 Lines
#if defined(LLVM_ON_UNIX) #if defined(LLVM_ON_UNIX)
if (munmap(Base.toPtr<void *>(), Size) != 0) if (munmap(Base.toPtr<void *>(), Size) != 0)
Err = joinErrors(std::move(Err), errorCodeToError(std::error_code( Err = joinErrors(std::move(Err), errorCodeToError(std::error_code(
errno, std::generic_category()))); errno, std::generic_category())));
#elif defined(_WIN32) #elif defined(_WIN32)
(void)Size;
if (!UnmapViewOfFile(Base.toPtr<void *>())) if (!UnmapViewOfFile(Base.toPtr<void *>()))
Err = joinErrors(std::move(Err), Err = joinErrors(std::move(Err),
errorCodeToError(mapWindowsError(GetLastError()))); errorCodeToError(mapWindowsError(GetLastError())));
CloseHandle(SharedMemoryFile); CloseHandle(SharedMemoryFile);
#endif #endif
▲ Show 20 Lines • Show All 90 Lines • Show Last 20 Lines