Add test cases when instruction selection for aarch64_neon_pmull64 intrinsic is sub-optimal.
This is to prepare for D131047, and makes diff clearer.
Differential D131045
[NFC][AArch64] Precommit test to optimize instruction selection for aarch64_neon_pmull64 intrinsic. mingmingl on Aug 2 2022, 11:11 PM. Authored by
Details Add test cases when instruction selection for aarch64_neon_pmull64 intrinsic is sub-optimal. This is to prepare for D131047, and makes diff clearer.
Diff Detail Event TimelineComment Actions Update revision title and summary. Use same comments for NFC and actual patch, so only assembly diff is shown in phabricator UI (not comment diff) From discussion with colleagues I should probably ask for review for both pre-commit tests and the actual change in the first place to ensure the quality of new test cases (e.g., not overly sensitive to changes that might make it brittle/likely to fail for unrelated reasons, not insufficiently minimized so that it's hard to maintain/read/possibly and more likely to fail for unrelated reasons, have good readability in terms of naming, etc) So do it now and will remember to ask reviews for both in the future. Hope it's not too late! |