Page MenuHomePhabricator

mingmingl (Mingming Liu)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 14 2021, 10:30 PM (36 w, 6 d)

Recent Activity

Tue, Jun 28

mingmingl updated the diff for D128302: [AArch64][CostModel] Detects that ExtractElement at index is not free in AArch64 when result is used as integer..

Change to AArch64TargetTransformInfo.cpp only:

  1. Add the missing continue for store operation check.
  2. Remove the OneUse restriction added for uitofpinst/sitofpinst.
Tue, Jun 28, 2:04 PM · Restricted Project, Restricted Project
mingmingl added inline comments to D128302: [AArch64][CostModel] Detects that ExtractElement at index is not free in AArch64 when result is used as integer..
Tue, Jun 28, 1:56 PM · Restricted Project, Restricted Project
mingmingl updated the diff for D128302: [AArch64][CostModel] Detects that ExtractElement at index is not free in AArch64 when result is used as integer..

In AArch64TargetTransformInfo.cpp, change helper function isExtractedElementUsedAsInteger by

  1. assert that all users of an instruction are instructions
  2. simplify the store operation usage check, since integer could only be directly used as value as it is, the source of store operation (i.e., not the destination to store the value to).
  3. require that uitofpinst/sitofpinst is the only use of extract-element if we think the extract-element operation is free.
Tue, Jun 28, 1:53 PM · Restricted Project, Restricted Project
mingmingl added inline comments to D128302: [AArch64][CostModel] Detects that ExtractElement at index is not free in AArch64 when result is used as integer..
Tue, Jun 28, 11:18 AM · Restricted Project, Restricted Project
mingmingl added a reviewer for D128302: [AArch64][CostModel] Detects that ExtractElement at index is not free in AArch64 when result is used as integer.: dmgreen.
Tue, Jun 28, 9:58 AM · Restricted Project, Restricted Project
mingmingl updated the diff for D128302: [AArch64][CostModel] Detects that ExtractElement at index is not free in AArch64 when result is used as integer..

For getVectorInstrCost method, optionally pass a pointer of Instruction, and each target can retrieve the (use) context and customize cost estimation. For AArch64 implementation, fall back to use VectorInsertExtractBaseCost rather than regard extract element at index 0 as a free operation.

Tue, Jun 28, 9:58 AM · Restricted Project, Restricted Project

Fri, Jun 24

mingmingl committed rGe0d069598bc8: [Inline] Annotate inline pass name with link phase information for analysis. (authored by mingmingl).
[Inline] Annotate inline pass name with link phase information for analysis.
Fri, Jun 24, 10:07 AM · Restricted Project, Restricted Project
mingmingl closed D125495: [Inline][Remark] Annotate inline pass name with link phase information for analysis..
Fri, Jun 24, 10:07 AM · Restricted Project, Restricted Project
mingmingl added a comment to D125495: [Inline][Remark] Annotate inline pass name with link phase information for analysis..

LGTM with a minor comment fix. Thanks!

Fri, Jun 24, 9:33 AM · Restricted Project, Restricted Project
mingmingl updated the diff for D125495: [Inline][Remark] Annotate inline pass name with link phase information for analysis..

Update the description of option --annotate-inline-phase.

Fri, Jun 24, 9:32 AM · Restricted Project, Restricted Project

Thu, Jun 23

mingmingl updated the diff for D125495: [Inline][Remark] Annotate inline pass name with link phase information for analysis..

Sync base to head.

Thu, Jun 23, 8:44 AM · Restricted Project, Restricted Project

Wed, Jun 22

mingmingl committed rGbc856eb3fc8a: [SampleProfile][Inline] Annotate sample profile inline remarks with link phase… (authored by mingmingl).
[SampleProfile][Inline] Annotate sample profile inline remarks with link phase…
Wed, Jun 22, 5:32 PM · Restricted Project, Restricted Project
mingmingl closed D126833: [SampleProfile][Inline] Annotate sample profile inline remarks with link phase (prelink/postlink) information..
Wed, Jun 22, 5:32 PM · Restricted Project, Restricted Project
mingmingl updated the diff for D126833: [SampleProfile][Inline] Annotate sample profile inline remarks with link phase (prelink/postlink) information..

Address comments, by using overloaded operator rather than hasValue() / getValue(), since the former is closer to std::optional in terms of style.

Wed, Jun 22, 5:06 PM · Restricted Project, Restricted Project
mingmingl committed rG67dc8021a179: [Support] Change TrackingStatistic and NoopStatistic to use uint64_t instead of… (authored by mingmingl).
[Support] Change TrackingStatistic and NoopStatistic to use uint64_t instead of…
Wed, Jun 22, 10:12 AM · Restricted Project, Restricted Project, Restricted Project
mingmingl closed D128070: [Support] Change TrackingStatistic and NoopStatistic to use uint64_t instead of unsigned.
Wed, Jun 22, 10:12 AM · Restricted Project, Restricted Project, Restricted Project

Tue, Jun 21

mingmingl added a comment to D128302: [AArch64][CostModel] Detects that ExtractElement at index is not free in AArch64 when result is used as integer..

Changing the cost model (even if it impacts other places) is the right thing to do here. We cannot accept such special cases in LICM.

Tue, Jun 21, 2:09 PM · Restricted Project, Restricted Project
mingmingl updated the summary of D128302: [AArch64][CostModel] Detects that ExtractElement at index is not free in AArch64 when result is used as integer..
Tue, Jun 21, 1:53 PM · Restricted Project, Restricted Project
mingmingl updated the summary of D128302: [AArch64][CostModel] Detects that ExtractElement at index is not free in AArch64 when result is used as integer..
Tue, Jun 21, 1:50 PM · Restricted Project, Restricted Project
mingmingl requested review of D128302: [AArch64][CostModel] Detects that ExtractElement at index is not free in AArch64 when result is used as integer..
Tue, Jun 21, 1:38 PM · Restricted Project, Restricted Project

Sat, Jun 18

mingmingl accepted D128122: [X86] Make sure SF is updated when optimizing for `jg/jge/jl/jle`.

thanks for root cause and quick fix! lgtm after resolving others' comments.

Sat, Jun 18, 3:55 PM · Restricted Project, Restricted Project
mingmingl added a comment to D128070: [Support] Change TrackingStatistic and NoopStatistic to use uint64_t instead of unsigned.

You may click Edit Revision to edit the summary and then run arc amend to update local commit message with the summary.
This way you will not append an item to History.

Sat, Jun 18, 3:19 PM · Restricted Project, Restricted Project, Restricted Project
mingmingl updated the diff for D128070: [Support] Change TrackingStatistic and NoopStatistic to use uint64_t instead of unsigned.
  1. Change NoopStatistic to use uint64_t, to use consistent type for TrackingStatistic and NoopStatistic.
Sat, Jun 18, 3:19 PM · Restricted Project, Restricted Project, Restricted Project

Fri, Jun 17

mingmingl updated the diff for D128070: [Support] Change TrackingStatistic and NoopStatistic to use uint64_t instead of unsigned.

No change to patch content; 2 updates commit message (keep commit message and differential summary consistent, and append differential revision link as the last line of commit message).

Fri, Jun 17, 1:28 PM · Restricted Project, Restricted Project, Restricted Project
mingmingl updated the summary of D128070: [Support] Change TrackingStatistic and NoopStatistic to use uint64_t instead of unsigned.
Fri, Jun 17, 1:05 PM · Restricted Project, Restricted Project, Restricted Project
mingmingl updated the summary of D128070: [Support] Change TrackingStatistic and NoopStatistic to use uint64_t instead of unsigned.
Fri, Jun 17, 1:05 PM · Restricted Project, Restricted Project, Restricted Project
mingmingl updated the diff for D128070: [Support] Change TrackingStatistic and NoopStatistic to use uint64_t instead of unsigned.

In llvm/unittests/ADT/StatisticTest.cpp line 45, use UINT64_C(0) rather than 0ll as suggested.

Fri, Jun 17, 1:03 PM · Restricted Project, Restricted Project, Restricted Project
mingmingl added a comment to D128070: [Support] Change TrackingStatistic and NoopStatistic to use uint64_t instead of unsigned.

I think this makes sense. Any chance to compare clang sizes with and without this change? I think it is fine to increase the size a bit as fixing the overflow problem is more important, but the number should still be useful.

Fri, Jun 17, 1:00 PM · Restricted Project, Restricted Project, Restricted Project
mingmingl retitled D128070: [Support] Change TrackingStatistic and NoopStatistic to use uint64_t instead of unsigned from [Stats] Change Value type from unsigned to uint64_t. to [Support] Change TrackingStatistic to use uint64_t instead of unsigned.
Fri, Jun 17, 12:54 PM · Restricted Project, Restricted Project, Restricted Project
mingmingl updated the diff for D128070: [Support] Change TrackingStatistic and NoopStatistic to use uint64_t instead of unsigned.

In struct Statistic from [1], change field value type from unsigned to uint64_t accordingly.

Fri, Jun 17, 12:51 PM · Restricted Project, Restricted Project, Restricted Project
mingmingl added reviewers for D128070: [Support] Change TrackingStatistic and NoopStatistic to use uint64_t instead of unsigned: RKSimon, bogner, reames.
Fri, Jun 17, 10:22 AM · Restricted Project, Restricted Project, Restricted Project
mingmingl added a reviewer for D128070: [Support] Change TrackingStatistic and NoopStatistic to use uint64_t instead of unsigned: MaskRay.
Fri, Jun 17, 10:02 AM · Restricted Project, Restricted Project, Restricted Project
mingmingl requested review of D128070: [Support] Change TrackingStatistic and NoopStatistic to use uint64_t instead of unsigned.
Fri, Jun 17, 10:02 AM · Restricted Project, Restricted Project, Restricted Project
mingmingl added a comment to D128019: [MachineBlockPlacementStats] Added check for "-filter-print-funcs" option to the machine-block-placement-stats.

If forgot to add Differential Revision, just leave it. Reverting a commit and recommitting just to add the information only adds more churn.
You can click "Add Action" -> "Close Revision" to manually close a revision.

Fri, Jun 17, 8:33 AM · Restricted Project, Restricted Project

Thu, Jun 16

mingmingl committed rG1e67385d28a4: [MachineBlockPlacementStats] Added check for "-filter-print-funcs" (authored by mingmingl).
[MachineBlockPlacementStats] Added check for "-filter-print-funcs"
Thu, Jun 16, 10:10 PM · Restricted Project, Restricted Project
mingmingl closed D128019: [MachineBlockPlacementStats] Added check for "-filter-print-funcs" option to the machine-block-placement-stats.
Thu, Jun 16, 10:09 PM · Restricted Project, Restricted Project
mingmingl updated the diff for D128019: [MachineBlockPlacementStats] Added check for "-filter-print-funcs" option to the machine-block-placement-stats.

No code change.

Thu, Jun 16, 10:02 PM · Restricted Project, Restricted Project
mingmingl added a reverting change for rG46d45df4516e: [MachineBlockPlacementStats] Add check for `-filter-print-funcs` option to…: rGb7d09557f6ef: Revert "[MachineBlockPlacementStats] Add check for `-filter-print-funcs` option….
Thu, Jun 16, 9:57 PM · Restricted Project, Restricted Project
mingmingl committed rGb7d09557f6ef: Revert "[MachineBlockPlacementStats] Add check for `-filter-print-funcs` option… (authored by mingmingl).
Revert "[MachineBlockPlacementStats] Add check for `-filter-print-funcs` option…
Thu, Jun 16, 9:57 PM · Restricted Project, Restricted Project
mingmingl committed rG46d45df4516e: [MachineBlockPlacementStats] Add check for `-filter-print-funcs` option to… (authored by mingmingl).
[MachineBlockPlacementStats] Add check for `-filter-print-funcs` option to…
Thu, Jun 16, 9:54 PM · Restricted Project, Restricted Project
mingmingl added reviewers for D128019: [MachineBlockPlacementStats] Added check for "-filter-print-funcs" option to the machine-block-placement-stats: davidxl, Carrot.
Thu, Jun 16, 5:27 PM · Restricted Project, Restricted Project
mingmingl requested review of D128019: [MachineBlockPlacementStats] Added check for "-filter-print-funcs" option to the machine-block-placement-stats.
Thu, Jun 16, 5:27 PM · Restricted Project, Restricted Project
mingmingl updated the diff for D127798: [AArch64] Define __ARM_FEATURE_RCPC.

Use --target=aarch64 rather than --target=aarch64-unknown-linux-gnu, given the former means all ELF based operating systems can expect the feature. (thanks maskray@ for pointing it out!)

Thu, Jun 16, 4:41 PM · Restricted Project, Restricted Project
mingmingl updated the diff for D127798: [AArch64] Define __ARM_FEATURE_RCPC.

change from -target=aarch64-none-linux-gnu to --target=aarch64-none-linux-gnu to resolve a compile error.

Thu, Jun 16, 4:26 PM · Restricted Project, Restricted Project
mingmingl added inline comments to D127798: [AArch64] Define __ARM_FEATURE_RCPC.
Thu, Jun 16, 1:43 PM · Restricted Project, Restricted Project
mingmingl updated the diff for D127798: [AArch64] Define __ARM_FEATURE_RCPC.

In clang/test/Preprocessor/aarch64-target-features.c, move __ARM_FEATURE_RCPC to keep the alphabetical list, and use -target=aarch64.. (the join style) rather than legacy while-space separated style (key value).

Thu, Jun 16, 1:42 PM · Restricted Project, Restricted Project
mingmingl added a comment to D127798: [AArch64] Define __ARM_FEATURE_RCPC.

Yes. Please submit a PR or Issue to the ACLE, explaining the use-case (the explanation here is good enough, I think).

Once the ACLE changes are merged, then you can proceed with a patch for clang.

Thu, Jun 16, 11:58 AM · Restricted Project, Restricted Project

Wed, Jun 15

mingmingl added a comment to D127798: [AArch64] Define __ARM_FEATURE_RCPC.

The patch looks correct to me, but looking at https://github.com/ARM-software/acle/blob/main/main/acle.md where all the ACLE macros are defined, I'm not sure that __ARM_FEATURE_RCPC is there currently. Maybe you also want to submit a patch there, or at least explain the context of this change please?

Wed, Jun 15, 10:49 AM · Restricted Project, Restricted Project

Tue, Jun 14

mingmingl added a reviewer for D127798: [AArch64] Define __ARM_FEATURE_RCPC: SjoerdMeijer.
Tue, Jun 14, 2:20 PM · Restricted Project, Restricted Project
mingmingl added a reviewer for D127798: [AArch64] Define __ARM_FEATURE_RCPC: tyb0807.
Tue, Jun 14, 2:18 PM · Restricted Project, Restricted Project
mingmingl updated the diff for D127798: [AArch64] Define __ARM_FEATURE_RCPC.

update commit message with differential revision link.

Tue, Jun 14, 2:16 PM · Restricted Project, Restricted Project
mingmingl requested review of D127798: [AArch64] Define __ARM_FEATURE_RCPC.
Tue, Jun 14, 2:14 PM · Restricted Project, Restricted Project

Wed, Jun 8

mingmingl added a comment to D126833: [SampleProfile][Inline] Annotate sample profile inline remarks with link phase (prelink/postlink) information..

thanks for reviews! PTAL.

Wed, Jun 8, 11:46 AM · Restricted Project, Restricted Project
mingmingl updated the diff for D126833: [SampleProfile][Inline] Annotate sample profile inline remarks with link phase (prelink/postlink) information..

Resolve comments, and add Differential Revision: <URL> in commit message.

Wed, Jun 8, 11:46 AM · Restricted Project, Restricted Project

Thu, Jun 2

mingmingl added a comment to D125495: [Inline][Remark] Annotate inline pass name with link phase information for analysis..

This patch is not ready for review (D126833 is the parent revision, and I'll need to merge D126824)

Thu, Jun 2, 2:18 PM · Restricted Project, Restricted Project
mingmingl updated the diff for D126833: [SampleProfile][Inline] Annotate sample profile inline remarks with link phase (prelink/postlink) information..

Revert unnecessary change in llvm/include/llvm/Transforms/IPO/SampleProfile.h

Thu, Jun 2, 2:05 PM · Restricted Project, Restricted Project
mingmingl added a comment to D126824: [Inline][Remark][NFC] Optionally provide inline context to inline advisor..

Upon reflection of static usage I realize there is a bug in this patch.

Thu, Jun 2, 2:02 PM · Restricted Project, Restricted Project
mingmingl updated the diff for D126833: [SampleProfile][Inline] Annotate sample profile inline remarks with link phase (prelink/postlink) information..
  • Fix a bug in InlineAdvisor::getAnnotatedInlinePassName (from https://reviews.llvm.org/D126824). Basically, to compute string only once, make it a constant member of class, and return its c_str() ever since.
Thu, Jun 2, 2:01 PM · Restricted Project, Restricted Project
mingmingl committed rG8601f269f109: [Inline][Remark][NFC] Optionally provide inline context to inline (authored by mingmingl).
[Inline][Remark][NFC] Optionally provide inline context to inline
Thu, Jun 2, 1:16 PM · Restricted Project, Restricted Project
mingmingl closed D126824: [Inline][Remark][NFC] Optionally provide inline context to inline advisor..
Thu, Jun 2, 1:15 PM · Restricted Project, Restricted Project
mingmingl updated the diff for D126824: [Inline][Remark][NFC] Optionally provide inline context to inline advisor..

Update commit message to the same as Phabricator summary, and a minor comment change

Thu, Jun 2, 12:51 PM · Restricted Project, Restricted Project
mingmingl retitled D126824: [Inline][Remark][NFC] Optionally provide inline context to inline advisor. from [Inline][Remark][NFC] Optionally provide inline advisor context information to inline advisor. to [Inline][Remark][NFC] Optionally provide inline context to inline advisor..
Thu, Jun 2, 12:47 PM · Restricted Project, Restricted Project
mingmingl retitled D126824: [Inline][Remark][NFC] Optionally provide inline context to inline advisor. from [Inline][Remark] Optionally provide inline advisor context information to inline advisor. to [Inline][Remark][NFC] Optionally provide inline advisor context information to inline advisor..
Thu, Jun 2, 12:45 PM · Restricted Project, Restricted Project

Wed, Jun 1

mingmingl updated the diff for D126824: [Inline][Remark][NFC] Optionally provide inline context to inline advisor..

Use a general struct name, and add entries for SampleProfileInliner, AlwaysInliner, MLInliner.

Wed, Jun 1, 7:00 PM · Restricted Project, Restricted Project
mingmingl added a comment to D126833: [SampleProfile][Inline] Annotate sample profile inline remarks with link phase (prelink/postlink) information..

This is a strict subset of https://reviews.llvm.org/D125495, to make that patch simpler.

Wed, Jun 1, 3:24 PM · Restricted Project, Restricted Project
mingmingl requested review of D126833: [SampleProfile][Inline] Annotate sample profile inline remarks with link phase (prelink/postlink) information..
Wed, Jun 1, 3:23 PM · Restricted Project, Restricted Project
mingmingl requested review of D126824: [Inline][Remark][NFC] Optionally provide inline context to inline advisor..
Wed, Jun 1, 1:38 PM · Restricted Project, Restricted Project

Tue, May 31

mingmingl updated the diff for D125495: [Inline][Remark] Annotate inline pass name with link phase information for analysis..

resolve the following compile failure and run ninja check-all to verify

Tue, May 31, 11:13 AM · Restricted Project, Restricted Project
mingmingl added a comment to D125495: [Inline][Remark] Annotate inline pass name with link phase information for analysis..

Just fwiw, the sample-profile annotation and default-inline-advisor annotation are orthogonal and gated by two different options. I'm willing to move either one into another patch if a smaller patch is easier to review :-)

Tue, May 31, 10:18 AM · Restricted Project, Restricted Project
mingmingl added a comment to D125495: [Inline][Remark] Annotate inline pass name with link phase information for analysis..

The patch annotates SampleProfile inline, as well as the inline passes that talks to DefaultInlineAdvisor to get an advice (CGSCC, ModuleInline, ReplayInline).

Tue, May 31, 10:08 AM · Restricted Project, Restricted Project
mingmingl updated the diff for D125495: [Inline][Remark] Annotate inline pass name with link phase information for analysis..

Add struct InlineAdvisorParams.

  • Ctor of inliner advisor provides this struct with two dimensional information.
  • Inline advice instances query this struct to get the annotation information.
Tue, May 31, 9:51 AM · Restricted Project, Restricted Project

May 12 2022

mingmingl added a comment to D125495: [Inline][Remark] Annotate inline pass name with link phase information for analysis..

It might be worth annotating the early inliner for PGO as well.

May 12 2022, 4:49 PM · Restricted Project, Restricted Project
mingmingl updated the diff for D125495: [Inline][Remark] Annotate inline pass name with link phase information for analysis..

Fix a build error for llvm-project/llvm/lib/Transforms/IPO/SampleProfile.cpp:613:1: error: expected ‘;’ before ‘}’ token

May 12 2022, 2:26 PM · Restricted Project, Restricted Project
mingmingl added a comment to D125495: [Inline][Remark] Annotate inline pass name with link phase information for analysis..

can you put the motivation in the description?

May 12 2022, 2:19 PM · Restricted Project, Restricted Project
mingmingl updated the diff for D125495: [Inline][Remark] Annotate inline pass name with link phase information for analysis..

Resolve the comments.

May 12 2022, 2:18 PM · Restricted Project, Restricted Project
mingmingl requested review of D125495: [Inline][Remark] Annotate inline pass name with link phase information for analysis..
May 12 2022, 12:29 PM · Restricted Project, Restricted Project

May 10 2022

mingmingl committed rGcb22cb2691d0: [X86] Fix 80 column violation in X86InstrInfo.cpp. NFC (authored by mingmingl).
[X86] Fix 80 column violation in X86InstrInfo.cpp. NFC
May 10 2022, 7:59 PM · Restricted Project, Restricted Project
mingmingl closed D125345: [X86] Fix 80 column violation in X86InstrInfo.cpp. NFC.
May 10 2022, 7:59 PM · Restricted Project, Restricted Project
mingmingl reopened D125345: [X86] Fix 80 column violation in X86InstrInfo.cpp. NFC.

Reopen to update commit message (https://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20220509/1036412.html)

May 10 2022, 7:57 PM · Restricted Project, Restricted Project
mingmingl added a reverting change for rG8bef5476de3e: [NFC] Run clang-format on llvm/lib/Target/X86/X86InstroInfo.cpp: rG852f3d998787: Revert "[NFC] Run clang-format on llvm/lib/Target/X86/X86InstroInfo.cpp".
May 10 2022, 7:54 PM · Restricted Project, Restricted Project
mingmingl committed rG852f3d998787: Revert "[NFC] Run clang-format on llvm/lib/Target/X86/X86InstroInfo.cpp" (authored by mingmingl).
Revert "[NFC] Run clang-format on llvm/lib/Target/X86/X86InstroInfo.cpp"
May 10 2022, 7:54 PM · Restricted Project, Restricted Project
mingmingl added a reverting change for D125345: [X86] Fix 80 column violation in X86InstrInfo.cpp. NFC: rG852f3d998787: Revert "[NFC] Run clang-format on llvm/lib/Target/X86/X86InstroInfo.cpp".
May 10 2022, 7:54 PM · Restricted Project, Restricted Project
mingmingl committed rG8bef5476de3e: [NFC] Run clang-format on llvm/lib/Target/X86/X86InstroInfo.cpp (authored by mingmingl).
[NFC] Run clang-format on llvm/lib/Target/X86/X86InstroInfo.cpp
May 10 2022, 5:57 PM · Restricted Project, Restricted Project
mingmingl closed D125345: [X86] Fix 80 column violation in X86InstrInfo.cpp. NFC.
May 10 2022, 5:57 PM · Restricted Project, Restricted Project
mingmingl updated the diff for D125345: [X86] Fix 80 column violation in X86InstrInfo.cpp. NFC.

Fix a typo

May 10 2022, 4:38 PM · Restricted Project, Restricted Project
mingmingl retitled D125345: [X86] Fix 80 column violation in X86InstrInfo.cpp. NFC from [NFC] Run clang-format on llvm/lib/Target/X86/X86InstrInfo.cpp to [X86] Fix 80 column violation in X86InstrInfo.cpp. NFC.
May 10 2022, 4:37 PM · Restricted Project, Restricted Project
mingmingl requested review of D125345: [X86] Fix 80 column violation in X86InstrInfo.cpp. NFC.
May 10 2022, 4:02 PM · Restricted Project, Restricted Project
mingmingl committed rGfc58d7a3261d: [Peephole-opt][X86] Enhance peephole opt to see through SUBREG_TO_REG (authored by mingmingl).
[Peephole-opt][X86] Enhance peephole opt to see through SUBREG_TO_REG
May 10 2022, 3:57 PM · Restricted Project, Restricted Project
mingmingl closed D124118: [Peephole-Opt][X86] Enhance peephole opt to see through SUBREG_TO_REG (following AND) and eliminates redundant TEST instruction..
May 10 2022, 3:57 PM · Restricted Project, Restricted Project
mingmingl retitled D124118: [Peephole-Opt][X86] Enhance peephole opt to see through SUBREG_TO_REG (following AND) and eliminates redundant TEST instruction. from [Peephole-Opt] For one kind of test-after-add pattern, eliminates test if it's correct to do so. to [Peephole-Opt][X86] Enhance peephole opt to see through SUBREG_TO_REG (following AND) and eliminates redundant TEST instruction..
May 10 2022, 2:44 PM · Restricted Project, Restricted Project
mingmingl added a reviewer for D124118: [Peephole-Opt][X86] Enhance peephole opt to see through SUBREG_TO_REG (following AND) and eliminates redundant TEST instruction.: reames.
May 10 2022, 2:34 PM · Restricted Project, Restricted Project
mingmingl updated subscribers of D124118: [Peephole-Opt][X86] Enhance peephole opt to see through SUBREG_TO_REG (following AND) and eliminates redundant TEST instruction..
May 10 2022, 2:33 PM · Restricted Project, Restricted Project
mingmingl updated the diff for D124118: [Peephole-Opt][X86] Enhance peephole opt to see through SUBREG_TO_REG (following AND) and eliminates redundant TEST instruction..

Reapply with a descriptive commit message.

May 10 2022, 2:31 PM · Restricted Project, Restricted Project
mingmingl reopened D124118: [Peephole-Opt][X86] Enhance peephole opt to see through SUBREG_TO_REG (following AND) and eliminates redundant TEST instruction..

Reopen so as to re-commit (upon request https://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20220509/1036289.html)

May 10 2022, 2:29 PM · Restricted Project, Restricted Project
mingmingl added a reverting change for rGd84ca05ef7f8: Enhance peephole optimization.: rG1555c41abb22: Revert "Enhance peephole optimization.".
May 10 2022, 2:00 PM · Restricted Project, Restricted Project
mingmingl committed rG1555c41abb22: Revert "Enhance peephole optimization." (authored by mingmingl).
Revert "Enhance peephole optimization."
May 10 2022, 2:00 PM · Restricted Project, Restricted Project
mingmingl added a reverting change for D124118: [Peephole-Opt][X86] Enhance peephole opt to see through SUBREG_TO_REG (following AND) and eliminates redundant TEST instruction.: rG1555c41abb22: Revert "Enhance peephole optimization.".
May 10 2022, 1:59 PM · Restricted Project, Restricted Project
mingmingl committed rGd84ca05ef7f8: Enhance peephole optimization. (authored by mingmingl).
Enhance peephole optimization.
May 10 2022, 12:39 PM · Restricted Project, Restricted Project
mingmingl closed D124118: [Peephole-Opt][X86] Enhance peephole opt to see through SUBREG_TO_REG (following AND) and eliminates redundant TEST instruction..
May 10 2022, 12:39 PM · Restricted Project, Restricted Project
mingmingl added inline comments to D124118: [Peephole-Opt][X86] Enhance peephole opt to see through SUBREG_TO_REG (following AND) and eliminates redundant TEST instruction..
May 10 2022, 12:07 PM · Restricted Project, Restricted Project