Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

[clang][ExtractAPI] Record availability information on all platforms
ClosedPublic
Actions

Authored by dang on Aug 1 2022, 10:55 AM.

Details

Reviewers

zixuw
QuietMisdreavus
ributzka

Commits

rG57c9780d60b1: [clang][ExtractAPI] Record availability information on all platforms

Summary

Currently ExtractAPI only emits availability information for the
current platform. This makes it easy for clients to get all availability
information for a given symbol in one invocation as opposed to having to invoke
clang once per-platform and then merge the symbol-graphs.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

dang created this revision.Aug 1 2022, 10:55 AM

Herald added a project: Restricted Project. · View Herald TranscriptAug 1 2022, 10:55 AM

Herald added a subscriber: mgorny. · View Herald Transcript

dang requested review of this revision.Aug 1 2022, 10:55 AM

Herald added a project: Restricted Project. · View Herald TranscriptAug 1 2022, 10:55 AM

Herald added a subscriber: cfe-commits. · View Herald Transcript

Thanks Daniel!

clang/test/ExtractAPI/availability.c
17	Do we care about doc comments for this particular test? The testing convention for all the ExtractAPI tests is probably not the most ideal one because every test is a complete matching of the full Symbol Graph output. So if we try to limit the scope of this test to just availability attributes it would be easier to read, and also avoid potential irrelevant failures in this test if something should broke the doc comment part.