User Details
User Details
- User Since
- Jan 20 2022, 10:44 AM (98 w, 2 d)
Mar 29 2023
Mar 29 2023
Oct 12 2022
Oct 12 2022
It would be ideal to be able to properly handle nested types like this, but for right now this is causing a crash in Swift-DocC, so this patch will at least get that working.
May 16 2022
May 16 2022
QuietMisdreavus added a comment to D125678: [clang][extract-api] Don't emit symbols prefixed with an underscore.
clang-format failed:
QuietMisdreavus accepted D125678: [clang][extract-api] Don't emit symbols prefixed with an underscore.
LGTM
Apr 8 2022
Apr 8 2022
QuietMisdreavus accepted D123391: [clang][extract-api] Emit "navigator" property of "name" in SymbolGraph.
Looks great, thanks!
QuietMisdreavus added a comment to D123391: [clang][extract-api] Emit "navigator" property of "name" in SymbolGraph.
This looks good! Just one question.
Apr 6 2022
Apr 6 2022
LGTM
LGTM
I like the idea of using the RAII context/guard to manage the path components stack. I have one non-blocking comment about the rest of the patch now.
Apr 5 2022
Apr 5 2022
QuietMisdreavus added inline comments to D123045: [clang][extract-api] Fix small issues with SymbolGraphSerializer.
Apr 4 2022
Apr 4 2022
QuietMisdreavus added a comment to D123045: [clang][extract-api] Fix small issues with SymbolGraphSerializer.
QuietMisdreavus added a comment to D123045: [clang][extract-api] Fix small issues with SymbolGraphSerializer.
After a quick scan comparing the current output of these symbol graphs with the primary library used for reading them, the last thing i can spot that's "off" is that the "function signature" is currently being serialized under a parameters field instead of the required functionSignature.
Jan 21 2022
Jan 21 2022
QuietMisdreavus added inline comments to D117809: [clang] Add an extract-api driver option.
Jan 21 2022, 2:24 PM · Restricted Project