Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

QuietMisdreavus (Victoria Mitchell)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 20 2022, 10:44 AM (98 w, 2 d)

Recent Activity

Mar 29 2023

QuietMisdreavus accepted D147138: [clang][ExtractAPI] Add queried symbol to parent contexts in libclang.
Mar 29 2023, 8:31 AM · Restricted Project, Restricted Project

Oct 12 2022

QuietMisdreavus accepted D135804: [clang][ExtractAPI] Ignore fully anonymous RecordDecls.

It would be ideal to be able to properly handle nested types like this, but for right now this is causing a crash in Swift-DocC, so this patch will at least get that working.

Oct 12 2022, 3:33 PM · Restricted Project, Restricted Project

May 16 2022

QuietMisdreavus added a comment to D125678: [clang][extract-api] Don't emit symbols prefixed with an underscore.

clang-format failed:

May 16 2022, 2:01 PM · Restricted Project, Restricted Project
QuietMisdreavus accepted D125678: [clang][extract-api] Don't emit symbols prefixed with an underscore.

LGTM

May 16 2022, 1:59 PM · Restricted Project, Restricted Project

Apr 8 2022

QuietMisdreavus accepted D123391: [clang][extract-api] Emit "navigator" property of "name" in SymbolGraph.

Looks great, thanks!

Apr 8 2022, 8:46 AM · Restricted Project, Restricted Project
QuietMisdreavus added a comment to D123391: [clang][extract-api] Emit "navigator" property of "name" in SymbolGraph.

This looks good! Just one question.

Apr 8 2022, 8:20 AM · Restricted Project, Restricted Project

Apr 6 2022

QuietMisdreavus accepted D123259: [clang][ExtractAPI] Fix appendSpace in DeclarationFragments.

LGTM

Apr 6 2022, 3:33 PM · Restricted Project, Restricted Project
QuietMisdreavus accepted D123261: [clang][ExtractAPI] Fix declaration fragments for ObjC methods.

LGTM

Apr 6 2022, 3:31 PM · Restricted Project, Restricted Project
QuietMisdreavus accepted D123045: [clang][extract-api] Fix small issues with SymbolGraphSerializer.

I like the idea of using the RAII context/guard to manage the path components stack. I have one non-blocking comment about the rest of the patch now.

Apr 6 2022, 8:12 AM · Restricted Project, Restricted Project

Apr 5 2022

QuietMisdreavus added inline comments to D123045: [clang][extract-api] Fix small issues with SymbolGraphSerializer.
Apr 5 2022, 7:37 AM · Restricted Project, Restricted Project

Apr 4 2022

QuietMisdreavus added a comment to D123045: [clang][extract-api] Fix small issues with SymbolGraphSerializer.

After a quick scan comparing the current output of these symbol graphs with the primary library used for reading them, the last thing i can spot that's "off" is that the "function signature" is currently being serialized under a parameters field instead of the required functionSignature.

Hmm, I was looking at the format specification at https://github.com/apple/swift-docc-symbolkit/blob/0a45209833f4a151212c1aa38e13cfc03b9462e4/openapi.yaml#L307, and I searched the term functionSignature in the spec but found no property with that name (except for the FunctionSignature schema that the parameters property is referring to). But anyway this should be a easy fix.

Apr 4 2022, 4:02 PM · Restricted Project, Restricted Project
QuietMisdreavus added a comment to D123045: [clang][extract-api] Fix small issues with SymbolGraphSerializer.

After a quick scan comparing the current output of these symbol graphs with the primary library used for reading them, the last thing i can spot that's "off" is that the "function signature" is currently being serialized under a parameters field instead of the required functionSignature.

Apr 4 2022, 2:17 PM · Restricted Project, Restricted Project

Jan 21 2022

QuietMisdreavus added inline comments to D117809: [clang] Add an extract-api driver option.
Jan 21 2022, 2:24 PM · Restricted Project