This is an archive of the discontinued LLVM Phabricator instance.

Fix downstream build failures downstream due to D130612.
AbandonedPublic

Authored by mravishankar on Jul 28 2022, 10:35 PM.

Details

Summary

Missing header creates downstream failures.

Diff Detail

Event Timeline

mravishankar created this revision.Jul 28 2022, 10:35 PM
mravishankar requested review of this revision.Jul 28 2022, 10:35 PM

Ok, sounds good. Ill just drop this change. Wonder why it doesnt trigger failures in MLIR itself.

Maybe it did between the two commits but we didn't notice. LLVM doesn't follow IWUY, so it could have worked because of some transitive include that got removed.

mravishankar abandoned this revision.Jul 29 2022, 9:15 AM

Ok, sounds good. Ill just drop this change. Wonder why it doesnt trigger failures in MLIR itself.

I see why it happened. This commit is before the patch D130612. I was trying to cherry pick D130612 and obviously this got missed. Thanks!