This is an archive of the discontinued LLVM Phabricator instance.

Differential D130733

[flang] Fix build failure
ClosedPublic

Authored by vdonaldson on Jul 28 2022, 2:53 PM.

Details

Reviewers
arnamoy10
shraiysh
klausler
Summary

Fix build failure

Diff Detail

Event Timeline

vdonaldson created this revision.Jul 28 2022, 2:53 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 28 2022, 2:53 PM
Herald added subscribers: mehdi_amini, jdoerfert. · View Herald Transcript
vdonaldson requested review of this revision.Jul 28 2022, 2:53 PM
vdonaldson added reviewers: arnamoy10, shraiysh, klausler.Jul 28 2022, 2:55 PM
klausler accepted this revision.Jul 28 2022, 2:59 PM
This revision is now accepted and ready to land.Jul 28 2022, 2:59 PM
Harbormaster completed remote builds in B178155: Diff 448447.Jul 28 2022, 3:56 PM
vdonaldson closed this revision.Jul 28 2022, 4:43 PM

https://reviews.llvm.org/D130733 in the comment

Revision Contents

PathSize
flang/
lib/
Lower/
7 lines

Diff 448447

flang/lib/Lower/OpenMP.cpp

Show First 20 Lines • Show All 55 Lines • ▼ Show 20 Lines std::visit(Fortran::common::visitors{
} }
}, },
[&](const Fortran::parser::Name &name) { sym = name.symbol; }}, [&](const Fortran::parser::Name &name) { sym = name.symbol; }},
ompObject.u); ompObject.u);
return sym; return sym;
} }
template <typename T> template <typename T>
static void createPrivateVarSyms(Fortran::lower::AbstractConverter &converter, static void
createPrivateVarSyms(Fortran::lower::AbstractConverter &converter,
const T *clause, const T *clause,
Block *lastPrivBlock = nullptr) { [[maybe_unused]] Block *lastPrivBlock = nullptr) {
const Fortran::parser::OmpObjectList &ompObjectList = clause->v; const Fortran::parser::OmpObjectList &ompObjectList = clause->v;
for (const Fortran::parser::OmpObject &ompObject : ompObjectList.v) { for (const Fortran::parser::OmpObject &ompObject : ompObjectList.v) {
Fortran::semantics::Symbol *sym = getOmpObjectSymbol(ompObject); Fortran::semantics::Symbol *sym = getOmpObjectSymbol(ompObject);
// Privatization for symbols which are pre-determined (like loop index // Privatization for symbols which are pre-determined (like loop index
// variables) happen separately, for everything else privatize here. // variables) happen separately, for everything else privatize here.
if (sym->test(Fortran::semantics::Symbol::Flag::OmpPreDetermined)) if (sym->test(Fortran::semantics::Symbol::Flag::OmpPreDetermined))
continue; continue;
bool success = converter.createHostAssociateVarClone(*sym); bool success = converter.createHostAssociateVarClone(*sym);
▲ Show 20 Lines • Show All 1,606 Lines • Show Last 20 Lines