This is an archive of the discontinued LLVM Phabricator instance.

[clangd] Upgrade vlog() to log() for preamble build stats
ClosedPublic

Authored by adamcz on Jul 27 2022, 7:37 AM.

Details

Summary

This is very useful information for better understanding performance and
preamble builds don't happen that often, so it's not that spammy.

Diff Detail

Event Timeline

adamcz created this revision.Jul 27 2022, 7:37 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 27 2022, 7:37 AM
adamcz requested review of this revision.Jul 27 2022, 7:37 AM
kadircet accepted this revision.Jul 28 2022, 8:45 AM
kadircet added inline comments.
clang-tools-extra/clangd/Preamble.cpp
555

what about also moving this log into TUScheduler.cpp::reportPreamble, in which we can also log whether this is a "first preamble" or not?

This revision is now accepted and ready to land.Jul 28 2022, 8:45 AM
adamcz added inline comments.Aug 1 2022, 6:08 AM
clang-tools-extra/clangd/Preamble.cpp
555

I considered that, but this isn't structured log or something you'd process automatically and it's already clear from context in that log file if it's first build or rebuild. I think it's simpler to keep the log line here, to match the error line below.

If you have a use case for this information let me know and I'll update this change, otherwise I'll just go with the simple solution.

This revision was landed with ongoing or failed builds.Aug 1 2022, 6:14 AM
This revision was automatically updated to reflect the committed changes.