This is very useful information for better understanding performance and
preamble builds don't happen that often, so it's not that spammy.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
clang-tools-extra/clangd/Preamble.cpp | ||
---|---|---|
555 | what about also moving this log into TUScheduler.cpp::reportPreamble, in which we can also log whether this is a "first preamble" or not? |
clang-tools-extra/clangd/Preamble.cpp | ||
---|---|---|
555 | I considered that, but this isn't structured log or something you'd process automatically and it's already clear from context in that log file if it's first build or rebuild. I think it's simpler to keep the log line here, to match the error line below. If you have a use case for this information let me know and I'll update this change, otherwise I'll just go with the simple solution. |
what about also moving this log into TUScheduler.cpp::reportPreamble, in which we can also log whether this is a "first preamble" or not?