This is an archive of the discontinued LLVM Phabricator instance.

Differential D130625

[NFC][flang] Post changes for D127137 and D130027
ClosedPublic

Authored by peixin on Jul 27 2022, 4:46 AM.

Details

Reviewers
arnamoy10
kiranchandramohan
jdoerfert
Commits
rG4640a8a22cba: [NFC][flang] Add FIXME for privatization of loop bounds in Bridge.cpp
rG7ac2500eb05f: [NFC][flang] Remove the unused header in Bridge.cpp
Summary

D130027 adds one unused header in Bridge.cpp. D127137 needs one FIXME
as commented.

Diff Detail

Event Timeline

peixin created this revision.Jul 27 2022, 4:46 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 27 2022, 4:46 AM
Herald added subscribers: mehdi_amini, jdoerfert. · View Herald Transcript
peixin requested review of this revision.Jul 27 2022, 4:46 AM
Herald added a reviewer: jdoerfert. · View Herald TranscriptJul 27 2022, 4:46 AM
Herald added a subscriber: sstefan1. · View Herald Transcript
arnamoy10 accepted this revision.Jul 27 2022, 5:16 AM

LGTM

This revision is now accepted and ready to land.Jul 27 2022, 5:16 AM
Harbormaster completed remote builds in B177836: Diff 448003.Jul 27 2022, 5:25 AM
clementval added a subscriber: clementval.Jul 27 2022, 5:46 AM

I think you can send these changes without review as NFC. Like that you can make two small commits with meaningful commit message. Here the commit title is not really useful.

peixin added a comment.Jul 27 2022, 7:10 AM
In D130625#3682107, @clementval wrote:

I think you can send these changes without review as NFC. Like that you can make two small commits with meaningful commit message. Here the commit title is not really useful.

OK. I will split it into two small commits with meaningful title and commit message.

Closed by commit rG7ac2500eb05f: [NFC][flang] Remove the unused header in Bridge.cpp (authored by peixin). · Explain WhyJul 27 2022, 8:21 AM
This revision was automatically updated to reflect the committed changes.
peixin added a commit: rG7ac2500eb05f: [NFC][flang] Remove the unused header in Bridge.cpp.
peixin added a commit: rG4640a8a22cba: [NFC][flang] Add FIXME for privatization of loop bounds in Bridge.cpp.Jul 27 2022, 8:38 AM

Revision Contents

PathSize
flang/
lib/
Lower/
1 line

Diff 448050

flang/lib/Lower/Bridge.cpp

Show All 38 Lines
#include "flang/Optimizer/Support/FIRContext.h" #include "flang/Optimizer/Support/FIRContext.h"
#include "flang/Optimizer/Support/FatalError.h" #include "flang/Optimizer/Support/FatalError.h"
#include "flang/Optimizer/Support/InternalNames.h" #include "flang/Optimizer/Support/InternalNames.h"
#include "flang/Optimizer/Transforms/Passes.h" #include "flang/Optimizer/Transforms/Passes.h"
#include "flang/Parser/parse-tree.h" #include "flang/Parser/parse-tree.h"
#include "flang/Runtime/iostat.h" #include "flang/Runtime/iostat.h"
#include "flang/Semantics/tools.h" #include "flang/Semantics/tools.h"
#include "mlir/Dialect/ControlFlow/IR/ControlFlowOps.h" #include "mlir/Dialect/ControlFlow/IR/ControlFlowOps.h"
#include "mlir/Dialect/OpenMP/OpenMPDialect.h"
#include "mlir/IR/PatternMatch.h" #include "mlir/IR/PatternMatch.h"
#include "mlir/Parser/Parser.h" #include "mlir/Parser/Parser.h"
#include "mlir/Transforms/RegionUtils.h" #include "mlir/Transforms/RegionUtils.h"
#include "llvm/Support/CommandLine.h" #include "llvm/Support/CommandLine.h"
#include "llvm/Support/Debug.h" #include "llvm/Support/Debug.h"
#include "llvm/Support/ErrorHandling.h" #include "llvm/Support/ErrorHandling.h"
#define DEBUG_TYPE "flang-lower-bridge" #define DEBUG_TYPE "flang-lower-bridge"
▲ Show 20 Lines • Show All 3,224 Lines • Show Last 20 Lines