This is an archive of the discontinued LLVM Phabricator instance.

Skip padding between buildid and filenames.
ClosedPublic

Authored by amharc on Jul 26 2022, 5:20 AM.

Details

Summary

The perf tool will left-pad the buildids to 40 characters[1] and some
buildid types supported by lld are shorter than that (e.g. md5 is only
32 characters long).

[1]
https://github.com/torvalds/linux/blob/7b58b82b86c8b65a2b57a4c6cb96a460654f9e09/tools/perf/util/dsos.c#L308

Diff Detail

Event Timeline

amharc created this revision.Jul 26 2022, 5:20 AM
Herald added a reviewer: Amir. · View Herald Transcript
Herald added a reviewer: maksfb. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a subscriber: ayermolo. · View Herald Transcript
amharc published this revision for review.Jul 26 2022, 5:21 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 26 2022, 5:21 AM
Amir added a comment.Jul 26 2022, 11:52 AM

Please rebase the diff past 0db13e10c5645de467cc15c60f4d955bcf9b9f5d to retrigger and fix pre-merge check failure.

amharc updated this revision to Diff 447797.Jul 26 2022, 12:24 PM

Rebase to fix test failures.

maksfb accepted this revision.Jul 26 2022, 2:22 PM

LGTM. Thanks for the fix.

This revision is now accepted and ready to land.Jul 26 2022, 2:22 PM

Please add "[BOLT]" prefix to the title and drop the trailing period before the commit. Or do you want me to commit for you?

This revision was automatically updated to reflect the committed changes.