This is an archive of the discontinued LLVM Phabricator instance.

Move "clang/Basic/TokenKinds.h" into a separate top-level module.
ClosedPublic

Authored by vsapsai on Jul 22 2022, 12:04 PM.

Details

Summary

Fixes modular build for clangPseudoGrammar from clang-tools-extra.

Starting from https://reviews.llvm.org/D126731 clangPseudoGrammar
doesn't depend on generated .inc headers but still depends on
"Basic/TokenKinds.h". It means clangPseudoGrammar depends on module
'Clang_Basic' which does depend on generated .inc headers. To avoid
these coarse dependencies and extra build steps, extract
"clang/Basic/TokenKinds.h" into a top-level module 'Clang_Basic_TokenKinds'.

rdar://97387951

Diff Detail

Event Timeline

vsapsai created this revision.Jul 22 2022, 12:04 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 22 2022, 12:04 PM
Herald added a subscriber: ributzka. · View Herald Transcript
vsapsai requested review of this revision.Jul 22 2022, 12:04 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 22 2022, 12:04 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
sammccall accepted this revision.Jul 22 2022, 1:51 PM

Thank you!

This revision is now accepted and ready to land.Jul 22 2022, 1:51 PM
iana accepted this revision.Jul 22 2022, 4:09 PM
This revision was landed with ongoing or failed builds.Jul 22 2022, 4:26 PM
This revision was automatically updated to reflect the committed changes.

Thanks for the reviews!