Implements:
- LWG3432 Missing requirement for comparison_category
Implements part of:
- P1614R2 The Mothership has Landed
Paths
| Differential D130295
[libc++] Uses operator<=> in string_view ClosedPublic Authored by Mordante on Jul 21 2022, 11:36 AM.
Details
Summary Implements:
Implements part of:
Diff Detail
Event Timeline
jloser added inline comments.
philnik added inline comments.
Comment Actions Thanks for the comments! I'll have a look at them.
Mordante added inline comments.
ldionne added inline comments.
Comment Actions All review comments relevant to this review have been resolved. The open issues will be done in followup patches.
avogelsgesang added inline comments.
Comment Actions LGTM, but please wait for other reviewers to be satisfied too. My understanding is that there will be a follow-up change to switch from common_type_t to __type_identity_t, as we discussed during live review just now.
Comment Actions Still looks good from my perspective.
Mordante added inline comments.
Mordante marked 3 inline comments as done. Comment ActionsRebased to test CI and addresses review comments. This revision is now accepted and ready to land.Aug 4 2022, 9:36 AM Closed by commit rG3818b4df1e10: [libc++] Uses operator<=> in string_view (authored by Mordante). · Explain WhyAug 4 2022, 10:13 AM This revision was automatically updated to reflect the committed changes. Mordante marked an inline comment as done. Mordante added inline comments. mumbleskates added inline comments.
Mordante added inline comments.
Revision Contents
Diff 449692 libcxx/docs/Status/Cxx2bIssues.csv
libcxx/docs/Status/SpaceshipProjects.csv
libcxx/include/__compare/ordering.h
libcxx/include/__string/char_traits.h
libcxx/include/string_view
libcxx/test/std/strings/char.traits/char.traits.specializations/char.traits.specializations.char/types.pass.cpplibcxx/test/std/strings/char.traits/char.traits.specializations/char.traits.specializations.char16_t/types.pass.cpp
libcxx/test/std/strings/char.traits/char.traits.specializations/char.traits.specializations.char32_t/types.compile.pass.cpp
libcxx/test/std/strings/char.traits/char.traits.specializations/char.traits.specializations.char8_t/types.pass.cpp
libcxx/test/std/strings/char.traits/char.traits.specializations/char.traits.specializations.wchar.t/types.pass.cpp
libcxx/test/std/strings/string.view/string.view.comparison/comparison.pass.cpp
libcxx/test/std/strings/string.view/string.view.comparison/comparison.verify.cpp
libcxx/test/support/constexpr_char_traits.h
libcxx/test/support/test_comparisons.h
|
I noticed the link was a review after making my changes, the same or string below.