This is an archive of the discontinued LLVM Phabricator instance.

[clangd] Mention whether compile flags were inferred in check mode
ClosedPublic

Authored by kadircet on Jul 21 2022, 1:27 AM.

Details

Summary

That way when looking at logs it's clear whether diagnostics are a
result of compile flags mismatch.

Diff Detail

Event Timeline

kadircet created this revision.Jul 21 2022, 1:27 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 21 2022, 1:27 AM
kadircet requested review of this revision.Jul 21 2022, 1:27 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 21 2022, 1:27 AM
ilya-biryukov accepted this revision.Jul 21 2022, 4:54 AM

LGTM.
Please note the NIT that arguably improves readability.

clang-tools-extra/clangd/tool/Check.cpp
114

NIT: maybe change the order of arguments and the format string placeholders?
it's a bit hard to swap arguments inside one's head when reading the code.

log("{1}, {0}!", "world", "Hello");
// vs
log("{0}, {1}!", "Hello", "world");
This revision is now accepted and ready to land.Jul 21 2022, 4:54 AM
This revision was automatically updated to reflect the committed changes.
kadircet marked an inline comment as done.